Change BeanManager treatment in CDI Lite#547
Merged
Ladicek merged 1 commit intojakartaee:masterfrom Oct 21, 2021
Merged
Conversation
Previously, the specification downright disallowed obtaining a `BeanManager` in CDI Lite. This makes portability from CDI Full to CDI Lite harder, which also manifests in the CDI TCK. Wit this commit, CDI Lite applications may obtain a `BeanManager`, but may only call methods inherited from `BeanContainer`.
graemerocher
approved these changes
Oct 21, 2021
Member
Author
|
I'm specifically adding @graemerocher as a reviewer for higher visibility. I think this is pretty straightforward to implement -- if you have a |
manovotn
approved these changes
Oct 21, 2021
Contributor
manovotn
left a comment
There was a problem hiding this comment.
Awesome! This is going to save us some headaches in TCKs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the specification downright disallowed obtaining
a
BeanManagerin CDI Lite. This makes portability from CDI Fullto CDI Lite harder, which also manifests in the CDI TCK.
Wit this commit, CDI Lite applications may obtain a
BeanManager,but may only call methods inherited from
BeanContainer.