Skip to content

Draft changes for packaging/deployment/lifecycle.#540

Closed
manovotn wants to merge 3 commits intojakartaee:masterfrom
manovotn:issue483
Closed

Draft changes for packaging/deployment/lifecycle.#540
manovotn wants to merge 3 commits intojakartaee:masterfrom
manovotn:issue483

Conversation

@manovotn
Copy link
Copy Markdown
Contributor

@manovotn manovotn commented Oct 8, 2021

Fixes #483

@Ladicek this is the draft I started around #483. It has TODOs in places where I think we will need mentions and links to build compatible extensions.

I know you wanted to write down the extension part so I thought you could (once we agree on this part) take this draft as a basis for #484. If you think it is better written all together, then we can close this PR.

@Ladicek
Copy link
Copy Markdown
Member

Ladicek commented Oct 11, 2021

I have to finish the extension API changes and submit a PR. After that, I can take over this PR, if you don't get to it sooner. Your call, I don't mind either way.

@manovotn
Copy link
Copy Markdown
Contributor Author

@Ladicek PR updated; I have marked most conversations as resolved, few are still open or semi-open.

@Ladicek
Copy link
Copy Markdown
Member

Ladicek commented Oct 12, 2021

3 references to bean_archive_full should IMHO point to bean_archive, I marked them with a comment. The other changed references are OK.

@manovotn
Copy link
Copy Markdown
Contributor Author

Addressed two of those links which were incorrect even before but were highlighted by the rename. The last one you pointed out is IMO correct. I also changed the wording in Packaging and deployment to your latest suggestion as I like it more.

@Ladicek I will leave this as a draft for you to build up on for #484 if that's ok.

@Ladicek
Copy link
Copy Markdown
Member

Ladicek commented Oct 12, 2021

OK cool, thanks!


In addition to rules defined in <<selection>>, the following rules apply.

An alternative is not available for injection, lookup or name resolution to classes in a module unless the module is a bean archive and the alternative is explicitly _selected_ for the bean archive or the application.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this sentence needs to be added back. I'll do it locally, just FYI.

@Ladicek
Copy link
Copy Markdown
Member

Ladicek commented Oct 21, 2021

I'm closing this, because it's superseded by #546.

@Ladicek Ladicek closed this Oct 21, 2021
@manovotn manovotn deleted the issue483 branch October 21, 2021 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Lite/Full split: define packaging/deployment/lifecycle

2 participants