fix: stream Immich multipart upload to avoid OOM#1034
Merged
jaimetur merged 1 commit intojaimetur:mainfrom Mar 16, 2026
Merged
Conversation
Owner
|
Thanks for this PR. Already merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates Immich asset uploads to use streamed multipart encoding to prevent high memory usage (and potential OOM) during uploads.
Closes #1033
Problem
Uploads to Immich were sent via
requests.post(..., files=...)inClassImmichPhotos.push_asset(...).With large files and/or concurrent uploads, multipart payload handling could cause excessive RAM usage.
Changes
push_assetto streamed multipart usingMultipartEncoderExitStack)Scope / Impact
This affects all upload flows that call
ClassImmichPhotos.push_asset(...), including:Tests
tests/test_immich_upload_streaming.pyfiles=argument is useduv run python -m unittest tests.test_immich_upload_streaming✅uv run python -m unittest(contains existing unrelated baseline failures)