Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I swear this has to be the final change for the devshell!
The user shell part the hook I previously wrote was just unnecessary and caused more issues than it should have. I found direnv to be a better solution than whatever I came up with that makes setup even better with one less command (no need for
nix develop, justcdto the project after it's been allowed). It's also not a strict prerequisite, anyone on Nix can still just use thenix developnormally.I've also went ahead and tidied up the Nix documentation for contributing, separating it to its own section, with an added a note for the graphics drivers problem for non-NixOS systems. I'll probably investigate that next and see if there's something that could be done about it.