fix: normalise steamuser config structure to prevent playlist creation crash#32
Merged
fix: normalise steamuser config structure to prevent playlist creation crash#32
Conversation
Fixes 'Cannot read properties of undefined (reading general)' when creating/updating/deleting playlists. readConfig() previously only fell back to a default structure when JSON.parse threw, so a real Wallpaper Engine config.json that exists on disk but lacks steamuser.general (common on a fresh install where playlists were never used) would return undefined for steamuser, crashing all mutation paths. Now the parsed object is normalised with ??= so all callers can safely assume the steamuser -> general -> playlists chain exists. Fixes #21 Co-authored-by: Jagrat Rao <jagrat7@users.noreply.github.com>
…turning defaults Previously all errors during config read were caught and defaulted to an empty structure. Now only missing file errors (ENOENT) return defaults; other errors like permission issues or malformed JSON are re-thrown so callers can handle them appropriately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes "Cannot read properties of undefined (reading 'general')" when creating playlists on machines where the Wallpaper Engine config.json exists but lacks the steamuser.general keys.
Closes #21
Generated with Claude Code