Skip to content

Ignore: Fix build on s390x this PR is failing#2119

Closed
pavolloffay wants to merge 1 commit intojaegertracing:mainfrom
pavolloffay:fix-ibm-build
Closed

Ignore: Fix build on s390x this PR is failing#2119
pavolloffay wants to merge 1 commit intojaegertracing:mainfrom
pavolloffay:fix-ibm-build

Conversation

@pavolloffay
Copy link
Copy Markdown
Member

@pavolloffay pavolloffay commented Jan 19, 2024

Which problem is this PR solving?

Description of the changes

How was this change tested?

Checklist

@pavolloffay
Fix build on s390x and ppc64le, this PR is failing
da0372f 
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5ffd926) 96.57% compared to head (da0372f) 96.57%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2119   +/-   ##
=======================================
  Coverage   96.57%   96.57%           
=======================================
  Files         254      254           
  Lines        7620     7620           
  Branches     1986     1986           
=======================================
  Hits         7359     7359           
  Misses        261      261

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pavolloffay
Copy link
Copy Markdown
Member Author

pavolloffay commented Jan 22, 2024

It fails on

#9 568.4 $ NODE_ENV=production REACT_APP_VSN_STATE=$(../../scripts/get-tracking-version.js) vite build
#9 576.0 vite v5.0.11 building for production...
#9 576.5 ✓ 0 modules transformed.
#9 576.5 [vite:build-html] memory access out of bounds
#9 576.5 file: /workspace/packages/jaeger-ui/index.html
#9 576.5 error during build:
#9 576.5 RuntimeError: memory access out of bounds
#9 576.5     at wasm://wasm/0063bf96:wasm-function[1558]:0x162080
#9 576.5     at wasm://wasm/0063bf96:wasm-function[249]:0x104dc0
#9 576.5     at wasm://wasm/0063bf96:wasm-function[1442]:0x15f2f9
#9 576.5     at module.exports.xxhashBase64Url (/workspace/node_modules/rollup/dist/wasm-node/bindings_wasm.js:159:14)
#9 576.5     at getXxhash (file:///workspace/node_modules/rollup/dist/es/shared/node-entry.js:16781:12)
#9 576.5     at FileEmitter.assignReferenceId (file:///workspace/node_modules/rollup/dist/es/shared/node-entry.js:18266:27)
#9 576.5     at FileEmitter.emitAsset (file:///workspace/node_modules/rollup/dist/es/shared/node-entry.js:18311:34)
#9 576.5     at FileEmitter.emitFile (file:///workspace/node_modules/rollup/dist/es/shared/node-entry.js:18181:25)
#9 576.5     at Object.emitFile (file:///workspace/node_modules/rollup/dist/es/shared/node-entry.js:17585:41)
#9 576.5     at fileToBuiltUrl (file:///workspace/node_modules/vite/dist/node/chunks/dep-V3BH7oO1.js:16718:43)
#9 576.7 error Command failed with exit code 1.
#9 576.7 info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
#9 ERROR: process "/bin/sh -c yarn install --frozen-lockfile && cd ./packages/jaeger-ui && yarn build" did not complete successfully: exit code: 1
------
 > [4/4] RUN  yarn install --frozen-lockfile && cd ./packages/jaeger-ui && yarn build:
576.5     at wasm://wasm/0063bf96:wasm-function[1442]:0x15f2f9
576.5     at module.exports.xxhashBase64Url (/workspace/node_modules/rollup/dist/wasm-node/bindings_wasm.js:159:14)
576.5     at getXxhash (file:///workspace/node_modules/rollup/dist/es/shared/node-entry.js:16781:12)
576.5     at FileEmitter.assignReferenceId (file:///workspace/node_modules/rollup/dist/es/shared/node-entry.js:18266:27)
576.5     at FileEmitter.emitAsset (file:///workspace/node_modules/rollup/dist/es/shared/node-entry.js:18311:34)
576.5     at FileEmitter.emitFile (file:///workspace/node_modules/rollup/dist/es/shared/node-entry.js:18181:25)
576.5     at Object.emitFile (file:///workspace/node_modules/rollup/dist/es/shared/node-entry.js:17585:41)
576.5     at fileToBuiltUrl (file:///workspace/node_modules/vite/dist/node/chunks/dep-V3BH7oO1.js:16718:43)
576.7 error Command failed with exit code 1.
576.7 info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
------
WARNING: No output specified with docker-container driver. Build result will only remain in the build cache. To push result image into registry use --push or to load image into docker use --load
Dockerfile:7
--------------------
   5 |     COPY . .
   6 |     
   7 | >>> RUN  yarn install --frozen-lockfile && cd ./packages/jaeger-ui && yarn build
   8 |     
--------------------
ERROR: failed to solve: process "/bin/sh -c yarn install --frozen-lockfile && cd ./packages/jaeger-ui && yarn build" did not complete successfully: exit code: 1

@pavolloffay pavolloffay mentioned this pull request Jan 22, 2024
Closed
@pavolloffay pavolloffay changed the title Ignore: Fix build on s390x and ppc64le, this PR is failing Ignore: Fix build on s390x this PR is failing Jan 22, 2024
@pavolloffay
Copy link
Copy Markdown
Member Author

pavolloffay commented Jan 22, 2024

The build on ppc64le passed docker buildx build --progress plain --platform linux/ppc64le --tag pavolloffay/jaeger-ui:s390x --build-arg=TARGETARCH=ppc64le -f ./Dockerfile .

#9 634.2 $ NODE_ENV=production REACT_APP_VSN_STATE=$(../../scripts/get-tracking-version.js) vite build
#9 641.1 vite v5.0.11 building for production...
#9 641.5 transforming...
#9 766.1 [BABEL] Note: The code generator has deoptimised the styling of /workspace/packages/plexus/src/LayoutManager/layout.worker.bundled.js as it exceeds the max of 500KB.
#9 791.7 ../../node_modules/store/plugins/lib/json2.js (493:20) Use of eval in "../../node_modules/store/plugins/lib/json2.js" is strongly discouraged as it poses security risks and may cause issues with minification.
#9 844.2 ✓ 5154 modules transformed.
#9 1083.7 rendering chunks...
#9 1101.7 computing gzip size...
#9 1102.5 build/static/polyfills-legacy-3eJXTa20.js     47.70 kB │ gzip:    18.93 kB
#9 1102.5 build/static/index-legacy-JJbhr7zv.js      4,932.04 kB │ gzip: 1,371.58 kB
#9 1102.5 
#9 1102.5 (!) Some chunks are larger than 500 kB after minification. Consider:
#9 1102.5 - Using dynamic import() to code-split the application
#9 1102.5 - Use build.rollupOptions.output.manualChunks to improve chunking: https://rollupjs.org/configuration-options/#output-manualchunks
#9 1102.5 - Adjust chunk size limit for this warning via build.chunkSizeWarningLimit.
#9 1114.8 build/static/favicon-cXFX9Gpm.ico          1.15 kB
#9 1114.8 build/index.html                           4.43 kB │ gzip:     1.82 kB
#9 1114.8 build/static/monitor-WK3oPUSr.png        111.77 kB
#9 1114.8 build/static/jaeger-logo-jWbKFHZJ.svg    161.92 kB │ gzip:    46.16 kB
#9 1114.8 build/static/index-xQKUpJMu.css           96.27 kB │ gzip:    21.30 kB
#9 1114.8 build/static/index-wZSqlyMU.js         5,018.42 kB │ gzip: 1,410.73 kB
#9 1114.8 
#9 1114.8 (!) Some chunks are larger than 500 kB after minification. Consider:
#9 1114.8 - Using dynamic import() to code-split the application
#9 1114.8 - Use build.rollupOptions.output.manualChunks to improve chunking: https://rollupjs.org/configuration-options/#output-manualchunks
#9 1114.8 - Adjust chunk size limit for this warning via build.chunkSizeWarningLimit.
#9 1114.8 ✓ built in 7m 54s
#9 1115.1 Done in 481.83s.
#9 DONE 1115.4s
WARNING: No output specified with docker-container driver. Build result will only remain in the build cache. To push result image into registry use --push or to load image into docker use --load
``

@yurishkuro
Copy link
Copy Markdown
Member

yurishkuro commented Jan 22, 2024

@pavolloffay why do we need UI build to work on s390x? The resulting artifacts should not be affected, and we have the main jaeger binaries built for s390x.

@pavolloffay
Copy link
Copy Markdown
Member Author

pavolloffay commented Jan 22, 2024

We need it internally. Or build pipeline needs to build everything from source for a given platform.

@pavolloffay pavolloffay mentioned this pull request Feb 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pavolloffay @yurishkuro