Conversation
… only in XML reports
Member
|
As we have this snippet now all over the place: I would like to propose to add a new method to |
Member
Author
|
@marchof added |
Member
|
@Godin Thx for adding
|
marchof
approved these changes
Jan 18, 2019
marchof
left a comment
Member
There was a problem hiding this comment.
Ok, I will add more isEmpty() use cases in a separate PR.
Member
Author
|
@marchof thanks for spotting this - made changes, hopefully correctly 😉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #806
Our own XML report before this change is 915700 bytes, after is 920811 - increase is just 0.6%.