Skip to content

Require at least JDK 21 for build#2128

Merged
Godin merged 2 commits into
jacoco:masterfrom
Godin:require_jdk21_for_build
May 23, 2026
Merged

Require at least JDK 21 for build#2128
Godin merged 2 commits into
jacoco:masterfrom
Godin:require_jdk21_for_build

Conversation

@Godin

@Godin Godin commented May 22, 2026

Copy link
Copy Markdown
Member

Closes #2087

@Godin Godin self-assigned this May 22, 2026
@Godin Godin added this to the 0.8.15 milestone May 22, 2026
Comment thread org.jacoco.build/pom.xml
Comment on lines +1028 to +1035
<!--
Unfortunately plexus-compiler-eclipse version 2.16.2
does not pass path to JDK selected by maven-toolchain-plugin
to ECJ using argument `system`.
As a result, ECJ uses the same JDK as Maven,
so validation tests that use classes from a particular JDK version
require Maven to be executed with at least that version.
-->

@Godin Godin May 22, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment explains build failures in #2061 and so this PR will fix them.
There other possible workarounds, but I prefer this change that is simpler and also will close #2087

@Godin Godin marked this pull request as ready for review May 22, 2026 21:07
@Godin Godin requested review from leveretka and marchof May 22, 2026 21:09
@Godin Godin enabled auto-merge (squash) May 22, 2026 21:50
@Godin Godin merged commit 3e18f17 into jacoco:master May 23, 2026
56 checks passed
@Godin Godin deleted the require_jdk21_for_build branch May 23, 2026 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SonarQube Cloud analysis should use JDK 21

2 participants