KotlinDefaultMethodsFilter should filter compatibility methods by Godin · Pull Request #1905 · jacoco/jacoco

Godin · 2025-10-28T21:18:13Z

See https://kotlinlang.org/docs/whatsnew22.html#changes-to-default-method-generation-for-interface-functions

For Example.kt

interface I {
  fun m() {
    print("default")
  }
}

class C : I { // line 7
}

Kotlin compiler version 2.1.0 produces

javap -v -p I.class

{
  public abstract void m();
    descriptor: ()V
    flags: (0x0401) ACC_PUBLIC, ACC_ABSTRACT
}

javap -v -p I\$DefaultImpls.class

  public static void m(I);
    descriptor: (LI;)V
    flags: (0x0009) ACC_PUBLIC, ACC_STATIC
    Code:
      stack=2, locals=1, args_size=1
         0: ldc           #9                  // String default
         2: getstatic     #15                 // Field java/lang/System.out:Ljava/io/PrintStream;
         5: swap
         6: invokevirtual #21                 // Method java/io/PrintStream.print:(Ljava/lang/Object;)V
         9: return
      LineNumberTable:
        line 3: 0
        line 4: 9

javap -v -p C.class

  public C();
    descriptor: ()V
    flags: (0x0001) ACC_PUBLIC
    Code:
      stack=1, locals=1, args_size=1
         0: aload_0
         1: invokespecial #10                 // Method java/lang/Object."<init>":()V
         4: return
      LineNumberTable:
        line 7: 0
      LocalVariableTable:
        Start  Length  Slot  Name   Signature
            0       5     0  this   LC;

  public void m();
    descriptor: ()V
    flags: (0x0001) ACC_PUBLIC
    Code:
      stack=1, locals=1, args_size=1
         0: aload_0
         1: invokestatic  #18                 // Method I$DefaultImpls.m:(LI;)V
         4: return
      LineNumberTable:
        line 7: 0
      LocalVariableTable:
        Start  Length  Slot  Name   Signature
            0       5     0  this   LC;

Kotlin compiler versions from 2.2.0 to 2.2.10 produce

javap -v -p I.class

  public default void m();
    descriptor: ()V
    flags: (0x0001) ACC_PUBLIC
    Code:
      stack=2, locals=1, args_size=1
         0: ldc           #8                  // String default
         2: getstatic     #14                 // Field java/lang/System.out:Ljava/io/PrintStream;
         5: swap
         6: invokevirtual #20                 // Method java/io/PrintStream.print:(Ljava/lang/Object;)V
         9: return
      LineNumberTable:
        line 3: 0
        line 4: 9
      LocalVariableTable:
        Start  Length  Slot  Name   Signature
            0      10     0  this   LI;

  public static void access$m$jd(I);
    descriptor: (LI;)V
    flags: (0x1009) ACC_PUBLIC, ACC_STATIC, ACC_SYNTHETIC
    Code:
      stack=1, locals=1, args_size=1
         0: aload_0
         1: invokespecial #26                 // InterfaceMethod m:()V
         4: return
      LineNumberTable:
        line 1: 1
      LocalVariableTable:
        Start  Length  Slot  Name   Signature
            0       5     0 $this   LI;

javap -v -p I\$DefaultImpls.class

  public static void m(I);
    descriptor: (LI;)V
    flags: (0x0009) ACC_PUBLIC, ACC_STATIC
    Code:
      stack=1, locals=1, args_size=1
         0: aload_0
         1: invokestatic  #13                 // InterfaceMethod I.access$m$jd:(LI;)V
         4: return
      LineNumberTable:
        line 2: 0
        line 4: 4
      LocalVariableTable:
        Start  Length  Slot  Name   Signature
            0       5     0 $this   LI;
    Deprecated: true
    RuntimeVisibleAnnotations:
      0: #7()
        java.lang.Deprecated
    RuntimeInvisibleParameterAnnotations:
      parameter 0:
        0: #8()
          org.jetbrains.annotations.NotNull

javap -v -p C.class

  public void m();
    descriptor: ()V
    flags: (0x0001) ACC_PUBLIC
    Code:
      stack=1, locals=1, args_size=1
         0: aload_0
         1: invokespecial #15                 // InterfaceMethod I.m:()V
         4: return
      LineNumberTable:
        line 7: 0
      LocalVariableTable:
        Start  Length  Slot  Name   Signature
            0       5     0  this   LC;

Methods I$DefaultImpls.m and C.m should be filtered out.

Kotlin compiler version 2.2.20 produces

javap -v -p I.class

  public default void m();
    descriptor: ()V
    flags: (0x0001) ACC_PUBLIC
    Code:
      stack=2, locals=1, args_size=1
         0: ldc           #8                  // String default
         2: getstatic     #14                 // Field java/lang/System.out:Ljava/io/PrintStream;
         5: swap
         6: invokevirtual #20                 // Method java/io/PrintStream.print:(Ljava/lang/Object;)V
         9: return
      LineNumberTable:
        line 3: 0
        line 4: 9
      LocalVariableTable:
        Start  Length  Slot  Name   Signature
            0      10     0  this   LI;

  public static void access$m$jd(I);
    descriptor: (LI;)V
    flags: (0x1009) ACC_PUBLIC, ACC_STATIC, ACC_SYNTHETIC
    Code:
      stack=1, locals=1, args_size=1
         0: aload_0
         1: invokespecial #26                 // InterfaceMethod m:()V
         4: return
      LineNumberTable:
        line 1: 1
      LocalVariableTable:
        Start  Length  Slot  Name   Signature
            0       5     0 $this   LI;

javap -v -p I\$DefaultImpls.class

  public static void m(I);
    descriptor: (LI;)V
    flags: (0x0009) ACC_PUBLIC, ACC_STATIC
    Code:
      stack=1, locals=1, args_size=1
         0: aload_0
         1: invokestatic  #13                 // InterfaceMethod I.access$m$jd:(LI;)V
         4: return
      LineNumberTable:
        line 2: 0
        line 4: 4
      LocalVariableTable:
        Start  Length  Slot  Name   Signature
            0       5     0 $this   LI;
    Deprecated: true
    RuntimeVisibleAnnotations:
      0: #7()
        java.lang.Deprecated
    RuntimeInvisibleParameterAnnotations:
      parameter 0:
        0: #8()
          org.jetbrains.annotations.NotNull

javap -v -p C.class

  public void m();
    descriptor: ()V
    flags: (0x0041) ACC_PUBLIC, ACC_BRIDGE
    Code:
      stack=1, locals=1, args_size=1
         0: aload_0
         1: invokespecial #15                 // InterfaceMethod I.m:()V
         4: return
      LineNumberTable:
        line 7: 0
      LocalVariableTable:
        Start  Length  Slot  Name   Signature
            0       5     0  this   LC;

Method I$DefaultImpls.m should be filtered.

https://groups.google.com/g/jacoco/c/QpoRB1Dn2BI/m/Rsa3N1GKAgAJ

Godin · 2025-07-28T20:49:26Z

@qwwdfsad similarly to #1752, #1557 and #1426
in this case compiler-generated non ACC_SYNTHETIC method
C.m has line number of class declaration line
I$DefaultImpls.m has line numbers of non compiler-generated I.m method
which according to https://youtrack.jetbrains.com/issue/KT-74091/K2-JvmOverloads-produced-overloads-have-generated-line-number-table

violates our rule about not having line numbers for compiler-produced "synthetic" (not ACC_SYNTHETIC) bodies

Godin self-assigned this Jun 27, 2025

Godin added type: enhancement component: core.filters language: Kotlin Tickets about Kotlin language support labels Jun 27, 2025

Godin added this to Filtering Jun 27, 2025

github-project-automation Bot moved this to Awaiting triage in Filtering Jun 27, 2025

Godin moved this from Awaiting triage to To Do in Filtering Jun 27, 2025

Godin changed the title ~~Filter compatibility bridges generated by Kotlin 2.2.0 for functions defined in interfaces~~ Filter compatibility bridges generated by Kotlin 2.2.0 - 2.2.10 for functions defined in interfaces Oct 28, 2025

Godin changed the title ~~Filter compatibility bridges generated by Kotlin 2.2.0 - 2.2.10 for functions defined in interfaces~~ Filter compatibility bridges generated by Kotlin 2.2.0 for functions defined in interfaces Oct 28, 2025

Godin added 2 commits October 28, 2025 22:03

(WIP) update validation test

79bd218

(WIP) add unit tests

fb72369

Godin added this to the 0.8.15 milestone Oct 28, 2025

(WIP) fix

5b0b0cd

Godin moved this from To Do to In Progress in Filtering Oct 28, 2025

Godin changed the title ~~Filter compatibility bridges generated by Kotlin 2.2.0 for functions defined in interfaces~~ KotlinDefaultMethodsFilter should filter compatibility methods Oct 28, 2025

(WIP) update changelog

1ce6753

Godin requested a review from leveretka October 28, 2025 21:25

leveretka approved these changes Oct 28, 2025

View reviewed changes

Godin enabled auto-merge (squash) October 29, 2025 08:56

Merge branch 'master' into kotlin_jvm-default

e05c8f3

Godin merged commit e50e23b into jacoco:master Oct 29, 2025
36 checks passed

Godin deleted the kotlin_jvm-default branch October 29, 2025 09:53

github-project-automation Bot moved this from In Progress to Done in Filtering Oct 29, 2025

psancheti6666 mentioned this pull request Apr 2, 2026

@JvmStatic in Kotlin interface companion object: synthetic Java-interop bridge reported as uncovered when called only from Kotlin #2096

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

KotlinDefaultMethodsFilter should filter compatibility methods#1905

KotlinDefaultMethodsFilter should filter compatibility methods#1905
Godin merged 5 commits into
jacoco:masterfrom
Godin:kotlin_jvm-default

Godin commented Oct 28, 2025 •

edited

Loading

Uh oh!

Godin commented Jul 28, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Godin commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Godin commented Jul 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Godin commented Oct 28, 2025 •

edited

Loading

Godin commented Jul 28, 2025 •

edited

Loading