MRG: Add support for channel types, add .DS_Store to .gitignore, add a conversion to str for fname#4
Merged
larsoner merged 5 commits intojackz314:mainfrom Apr 25, 2022
mscheltienne:improvements
Merged
MRG: Add support for channel types, add .DS_Store to .gitignore, add a conversion to str for fname#4larsoner merged 5 commits intojackz314:mainfrom mscheltienne:improvements
larsoner merged 5 commits intojackz314:mainfrom
mscheltienne:improvements
Conversation
… a pathlib.Path is provided instead.
3 tasks
Contributor
Author
|
@jackz314 pinging for review. |
5 tasks
Collaborator
|
Thanks @mscheltienne ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, I had to move some of my
-raw.fiffiles to EEGLAB; and I noticed the lack of support for channels types (which is problematic for me). I'm adding it here, using the example channel types provided here.A quick test shows that everything is working; the now loaded
.setfile in EEGLAB does show the correct channel types.Please correct me if I'm wrong or if I overlooked anything.
I'm not adding anything to the test (yet) because
mne.io.read_raw_eeglab()doesn't seem to support reading the channel types anyway. I will add it there as well when MNE release a version including mne-tools/mne-python#9990I also added 2 more small improvements:
.DS_Storeto the .gitignore for macOS developers.str(fname)before callingscipy.io.savemat. It's not uncommon for users to provide the path to a file as apathlib.Pathinstance and this would raise an error in scipy.