Skip to content

fix(extension): change automation window state from minimized to normal#531

Merged
jackwener merged 1 commit intojackwener:mainfrom
Astro-Han:worktree-fix-minimized-state
Mar 28, 2026
Merged

fix(extension): change automation window state from minimized to normal#531
jackwener merged 1 commit intojackwener:mainfrom
Astro-Han:worktree-fix-minimized-state

Conversation

@Astro-Han
Copy link
Copy Markdown
Contributor

@Astro-Han Astro-Han commented Mar 28, 2026

Description

chrome.windows.create with state: 'minimized' (introduced in #521) fails when combined with width/height parameters. The Chrome Extensions API explicitly prohibits this combination:

The minimized, maximized, and fullscreen states cannot be combined with left, top, width, or height.

This caused opencli doctor (and all browser commands) to fail with "Invalid value for state".

Fix: revert state: 'minimized' to state: 'normal'. The 30s idle timeout from #521 is preserved.

Fixes #526

Type of Change

  • 🐛 Bug fix

Checklist

  • I ran the checks relevant to this PR
  • I updated tests or docs if needed
  • I included output or screenshots when useful

Screenshots / Output

Before (from #526):

[FAIL] Connectivity: failed (Invalid value for state)

After:

[OK] Connectivity: connected in 1.0s

@Astro-Han Astro-Han force-pushed the worktree-fix-minimized-state branch from a34a215 to 4b3eab1 Compare March 28, 2026 02:15
chrome.windows.create rejects state:'minimized' when combined with
width/height (Chrome API constraint). Revert to state:'normal' to fix
the "Invalid value for state" error. The 30s idle timeout from jackwener#521
is preserved.

Fixes jackwener#526
@Astro-Han Astro-Han force-pushed the worktree-fix-minimized-state branch from 4b3eab1 to 99020c8 Compare March 28, 2026 02:31
@Astro-Han Astro-Han changed the title fix(extension): use normal window state instead of minimized fix(extension): change automation window state from minimized to normal Mar 28, 2026
@jackwener jackwener merged commit 5ab3f5d into jackwener:main Mar 28, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Connectivity: failed (Invalid value for state)

2 participants