perf: parallel file discovery and external CLI caching#501
Merged
Conversation
- Parallelize file scanning in discoverClisFromFs and discoverPluginDir using Promise.all(files.map(async ...)) instead of serial for-of with await, so isCliModule checks run concurrently - Parallelize plugin directory scanning in discoverPlugins - Cache loadExternalClis() result to avoid re-parsing YAML on every call - Invalidate cache in registerExternalCli after writing to disk - Cache strategyLabel() call in list command to avoid redundant computation - Add comment explaining why discovery must remain sequential (plugin override semantics)
d018408 to
4968c2e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
discoverClisFromFsanddiscoverPluginDir—isCliModulechecks now run concurrently viaPromise.all(files.map(async ...))instead of serialfor-ofwithawaitdiscoverPluginsloadExternalClis()result to avoid re-parsing YAML on repeated calls, with proper invalidation inregisterExternalClistrategyLabel()call in list commandTest plan
tsc --noEmitpasses