fix(plugin): detect symlinked monorepo sub-plugins in discoverPlugins#487
Merged
jackwener merged 2 commits intojackwener:mainfrom Mar 27, 2026
Merged
Conversation
discoverPlugins() used entry.isDirectory() to filter plugin directories, but monorepo sub-plugins are installed as symlinks pointing into ~/.opencli/monorepos/. On most Node.js versions, isDirectory() returns false for symlinks, causing monorepo plugin commands to be silently skipped during discovery. Add entry.isSymbolicLink() check so symlinked plugin directories are properly discovered and their commands registered.
3ba77e9 to
caefcb0
Compare
Owner
|
Thanks for the contribution! I pushed a small follow-up fix to keep symlinked monorepo plugins discoverable without letting broken symlinks turn startup into a failure. The overall discovery direction here is solid. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
discoverPlugins()usesentry.isDirectory()to filter plugin directories, but monorepo sub-plugins are installed as symlinks pointing into~/.opencli/monorepos/. On most Node.js versions,isDirectory()returnsfalsefor symlinks, causing monorepo plugin commands to be silently skipped during discovery.Fix
Add
entry.isSymbolicLink()check so symlinked plugin directories are properly discovered and their commands registered.Testing
All 337 unit tests pass.