fix(twitter): use DOM-only scraping for trending to match page results#486
Merged
jackwener merged 1 commit intojackwener:mainfrom Mar 27, 2026
Merged
Conversation
Remove guide.json API path that returned data inconsistent with what users see on the page (jackwener#463). Use semantic caret button detection via data-testid instead of position-based heuristics, and validate post count text contains digits before displaying.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove the
guide.jsonAPI path fromtwitter trendingcommand. The API returned data inconsistent with what users see on the trending page, causing #463.Now uses DOM-only scraping with semantic caret button detection (
data-testid="caret") instead of position-based heuristics, and validates post count text contains digits before displaying.Related issue: #463
Type of Change
Checklist
Screenshots / Output