Skip to content

fix: stabilize http download temp file handling#443

Merged
jackwener merged 1 commit intomainfrom
codex/fix-http-download-tempfile
Mar 25, 2026
Merged

fix: stabilize http download temp file handling#443
jackwener merged 1 commit intomainfrom
codex/fix-http-download-tempfile

Conversation

@jackwener
Copy link
Copy Markdown
Owner

Summary

  • rewrite httpDownload temp-file lifecycle to avoid stream cleanup races
  • avoid creating temp files for redirects and non-200 responses
  • keep progress accounting in-stream while waiting for pipeline completion before rename

Verification

  • npx vitest run src/download/index.test.ts --project unit --reporter=verbose
  • repeated the same test file 10 times successfully
  • npm run typecheck

@jackwener jackwener merged commit ed706f6 into main Mar 25, 2026
22 checks passed
@jackwener jackwener deleted the codex/fix-http-download-tempfile branch March 25, 2026 16:01
@jackwener jackwener mentioned this pull request Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant