fix(stealth): review fixes — guard plugins, rewrite stack trace cleanup#320
Merged
fix(stealth): review fixes — guard plugins, rewrite stack trace cleanup#320
Conversation
- Only override navigator.plugins when empty (don't replace real user browser plugins with fakes) - Replace Error.prepareStackTrace (V8/Node-only) with Error.prototype.stack getter override that works in browser context - Fix \\n escaping in template literal for stack trace split/join - Dynamic cdc_ variable scan via getOwnPropertyNames instead of hardcoded names - Update tests to cover 7 patches
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Review follow-up fixes for the stealth anti-detection module (#319):
Bug fixes
navigator.pluginswhen empty — on a real user browser, plugins are already populated with genuine values. Overwriting them with fakes was counterproductive and detectable.Error.prepareStackTrace(V8/Node-only, doesn't work in browser) withError.prototype.stackgetter override — correctly interceptsnew Error().stackreads in browser page context.\\nescaping in template literal — was causingSyntaxError: Invalid or unexpected tokenin the generated JS.Improvements
cdc_variable scan viaObject.getOwnPropertyNames(window)instead of hardcoded 3 variable names — adapts to all ChromeDriver versions.All 325 tests pass ✅