fix(e2e): broaden xiaoyuzhou skip logic for overseas CI runners#316
Merged
fix(e2e): broaden xiaoyuzhou skip logic for overseas CI runners#316
Conversation
Squash merge left a duplicate import line causing TS2300 and oxc parse errors in CI. Also clean up stale blank lines in discovery.ts and execution.ts.
The isExpectedChineseSiteRestriction function only matched FETCH_ERROR with specific HTTP status codes. On overseas CI runners, xiaoyuzhou may also return PARSE_ERROR (mangled HTML) or NOT_FOUND (geo-redirected pages), causing false test failures. Now matches all CliError codes from the adapter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes E2E CI failure on main.
The
isExpectedChineseSiteRestrictionfunction only matchedFETCH_ERRORwith HTTP 403/429/451/503. On overseas CI runners, xiaoyuzhou may also returnPARSE_ERROR(mangled HTML) orNOT_FOUND(geo-redirected pages), causing false test failures.Now matches all CliError codes from the xiaoyuzhou adapter +
fetch failedfor DNS/network issues.