feat: refine error handling with semantic error types#312
Merged
Conversation
- Add 5 new CliError subclasses: AuthRequiredError, TimeoutError, ArgumentError, EmptyResultError, SelectorError - Centralize getErrorMessage() and ERROR_ICONS in errors.ts - Data-driven error rendering in commanderAdapter.ts (replaces 5 if/else) - withTimeoutMs accepts factory function for backward compatibility - browser/errors.ts returns BrowserConnectError instead of bare Error - Migrate 5 benchmark adapters to AuthRequiredError - 318 unit tests passing, 0 regressions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AuthRequiredError,TimeoutError,ArgumentError,EmptyResultError,SelectorErrorgetErrorMessage()andERROR_ICONSin errors.ts (eliminates 5 duplicate definitions)withTimeoutMsaccepts factory function for backward compatibilitybrowser/errors.tsreturnsBrowserConnectErrorinstead of bareErrorAuthRequiredErrorTesting
errors.test.tscovers all 9 error typesFiles changed (14)
errors.ts,browser/errors.ts,runtime.ts,execution.ts,commanderAdapter.ts,discovery.ts,validate.ts,build-manifest.ts,errors.test.ts, + 5 adapter migrations