chore: pre-release cleanup — fix dependencies, sync docs, reduce code duplication#311
Merged
chore: pre-release cleanup — fix dependencies, sync docs, reduce code duplication#311
Conversation
… duplication - fix: move @types/turndown from dependencies to devDependencies - docs: backfill CHANGELOG for v1.2.0 through v1.3.1 - docs: remove internal release reminder from READMEs - docs: update SKILL.md version to 1.3.1 - refactor: extract getErrorMessage() to errors.ts (was duplicated 5x) - refactor: introduce CommandArgs type alias in registry.ts - refactor: eliminate as-any in runtime.ts and cli.ts - refactor: parallelize site directory scanning in discovery.ts - refactor: add declare global for registry globalThis access - fix: strengthen isBooleanRecord type guard in explore.ts - fix: replace empty catch with log.debug in explore.ts - fix: daemon now accepts timeout from request body - chore: remove unused REGISTRY_KEY constant - chore: update generate.ts TODO to stub annotation
ff83b93 to
594caac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pre-release cleanup for v1.4.0, addressing 15 issues found during deep review.
P0 — Release Blockers
@types/turndownmoved fromdependenciestodevDependenciesP1 — Code Quality
getErrorMessage()extracted toerrors.ts(was duplicated in 5 files)as anyeliminated inruntime.tsandcli.tsgenerate.tsTODO replaced with explicit stub annotationexplore.tsempty catch block replaced withlog.debugP2 — Improvements
registry.ts—CommandArgstype alias,declare global,strategyLabeluses enumdiscovery.ts— parallelized site directory scanning for faster dev startupexplore.ts—isBooleanRecordtype guard now validates all valuesdaemon.ts— command timeout is now configurable via request bodyVerification
tsc --noEmitpasses17 files changed, 168 insertions(+), 56 deletions(-)