fix(external): replace execSync with execFileSync to prevent command injection#309
Merged
jackwener merged 3 commits intojackwener:mainfrom Mar 23, 2026
Merged
Conversation
Owner
|
Reviewed and pushed two follow-up fixes onto this branch:
Local validation: |
fbe9799 to
ec3d892
Compare
Owner
|
@0xsline Thanks for the contribution. The core security direction was right; I pushed a small follow-up for Windows compatibility and rebased it onto current , then verified , , and . Merging now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
execSync(cmd)withexecFileSync(binary, args)ininstallExternalClito prevent command injection from YAML config filesparseCommand()helper that safely tokenizes command strings, respecting quoted segments&&,||,|,;,>,<, backticks) with a clear error messageexecSyncimportMotivation
The
cmdstring passed toexecSyncoriginates from YAML config files (install.mac,install.linux, etc.). If a malicious YAML is loaded via plugin, this is a command injection vector.execFileSyncdoes not invoke a shell, eliminating this risk.Test plan
opencli doctorstill works after changegh) still functions correctly