Skip to content

Refactor: Use Obsidian Platform API#10

Merged
jacksteamdev merged 3 commits intomainfrom
fix--use-obsidian-platform-api
Jan 8, 2025
Merged

Refactor: Use Obsidian Platform API#10
jacksteamdev merged 3 commits intomainfrom
fix--use-obsidian-platform-api

Conversation

@jacksteamdev
Copy link
Copy Markdown
Owner

Description

This PR includes several improvements to development setup and platform handling across the codebase:

Development Setup

  • Updates the symlink script to target the project root instead of just the plugin directory
  • Improves path resolution and error messages for development setup
  • Adds clearer documentation for setting up local development

Platform Handling

  • Switches to using Obsidian's built-in Platform utilities instead of Node's process.platform
  • Provides more reliable platform detection in the Obsidian context
  • Simplifies platform-specific code paths

Code Cleanup

  • Removes unused isClaudeDesktopInstalled() function as Claude config is handled elsewhere
  • Improves variable naming and path handling throughout
  • Better separation of concerns in platform-specific code

Testing

  • Tested symlink creation on Windows
  • Tested symlink creation on MacOS
  • Verified folder opening works on all platforms
  • Confirmed plugin installation still works correctly

These changes make the codebase more maintainable and provide a better development experience while simplifying platform-specific handling.

@jacksteamdev jacksteamdev merged commit d08bdf4 into main Jan 8, 2025
@jacksteamdev jacksteamdev mentioned this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant