Drop Node < 4 and refactor with ES2015 features#134
Merged
jameelmoses merged 3 commits intojackfranklin:masterfrom Jun 28, 2019
TheDancingCode:es2015
Merged
Drop Node < 4 and refactor with ES2015 features#134jameelmoses merged 3 commits intojackfranklin:masterfrom TheDancingCode:es2015
jameelmoses merged 3 commits intojackfranklin:masterfrom
TheDancingCode:es2015
Conversation
Implements const/let, template literals and arrow functions.
Owner
|
Hey @TheDancingCode, I'm so sorry this PR has sat for so long, there's really no excuse for that and I'm sorry. I think we should defo be updating + modernising the code. @pioug and @jameelmoses are maintaining this now so I'll let them pick it up 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up on #128, I refactored the code with some es2015 features like
const/let, template literals and arrow functions in certain places.