Skip to content

Replace engines.npm with packageManager#87

Merged
jackdomleo7 merged 3 commits intomasterfrom
npm-fix
Mar 25, 2023
Merged

Replace engines.npm with packageManager#87
jackdomleo7 merged 3 commits intomasterfrom
npm-fix

Conversation

@jackdomleo7
Copy link
Owner

Description

  • Resolve issue where consuming projects displayed a warning if they were not using npm 9. npm 9 is just the package manager being used within the project, consuming projects do not require it.

Why is this important?

  • False warnings are not good

Did you test on all major browsers?

  • Chrome
  • Firefox
  • Edge
  • Safari

Other details

N/A


T&Cs

  • I confirm I have read and understand the contributing guidelines
  • I understand the work in this pull request will not be released straight away and will appear in a future release (if approved)
  • I confirm the work in this pull request is true and valid to the best of my knowledge

@jackdomleo7 jackdomleo7 added the bug Something isn't working label Mar 25, 2023
@jackdomleo7 jackdomleo7 self-assigned this Mar 25, 2023
@jackdomleo7 jackdomleo7 merged commit 6b18dfc into master Mar 25, 2023
@jackdomleo7 jackdomleo7 deleted the npm-fix branch March 25, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant