Skip to content

Ensure license comment appears first in the stylesheet#82

Merged
jackdomleo7 merged 1 commit intomasterfrom
62-license
Jan 21, 2023
Merged

Ensure license comment appears first in the stylesheet#82
jackdomleo7 merged 1 commit intomasterfrom
62-license

Conversation

@jackdomleo7
Copy link
Owner

@jackdomleo7 jackdomleo7 commented Jan 21, 2023


name: 🐞 Bug fix
about: Submit a bug fix
labels: bug
title: '[BUG FIX]: Fix license comment appearing at the top of the stylesheet'

Bug description

Root cause

  • For some reason, the @use was taking precedence over the important comment

Solution description

  • By putting the important comment into a _license.scss file and importing into main.scss via @use, we can easily resolve this

Did you test on all major browsers?

I couldn't test Safari because I don't have access to an Apple device

  • Chrome
  • Firefox
  • Edge
  • Safari

Other details

N/A


T&Cs

  • I confirm I have read and understand the contributing guidelines
  • I understand the work in this pull request will not be released straight away and will appear in a future release (if approved)
  • I confirm the work in this pull request is true and valid to the best of my knowledge

@jackdomleo7 jackdomleo7 self-assigned this Jan 21, 2023
@jackdomleo7 jackdomleo7 added the bug Something isn't working label Jan 21, 2023
@jackdomleo7 jackdomleo7 merged commit 62d8538 into master Jan 21, 2023
@jackdomleo7 jackdomleo7 deleted the 62-license branch January 21, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: Important comment appears in the middle of the stylesheet rather than at the start

1 participant