Skip to content

Hide tooltip if attribute is empty#69

Merged
jackdomleo7 merged 1 commit intomasterfrom
64_dont_show_tooltips_on_empty_attributes
Nov 11, 2021
Merged

Hide tooltip if attribute is empty#69
jackdomleo7 merged 1 commit intomasterfrom
64_dont_show_tooltips_on_empty_attributes

Conversation

@jackdomleo7
Copy link
Owner

Enhancement/maintenance description

Why is this enhancement/maintenance important?

  • It seems unnecessary to display a tooltip with empty content. This could happen if you're programmatically generating the HTML, so is a good catch.

Did you test on all major browsers?

I couldn't test Safari because I don't have access to an Apple device.

  • Chrome
  • Firefox
  • Edge
  • Safari

Other details

N/A


T&Cs

  • I confirm I have read and understand the contributing guidelines
  • I understand the work in this pull request will not be released straight away and will appear in a future release (if approved)
  • I confirm the work in this pull request is true and valid to the best of my knowledge

@jackdomleo7 jackdomleo7 added the enhancement New feature or request label Nov 11, 2021
@jackdomleo7 jackdomleo7 self-assigned this Nov 11, 2021
@jackdomleo7 jackdomleo7 merged commit cd2e4a8 into master Nov 11, 2021
@jackdomleo7 jackdomleo7 deleted the 64_dont_show_tooltips_on_empty_attributes branch November 11, 2021 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE]: Exclude empty aria-label

1 participant