Skip to content

Customise attribute the tooltip is bound to#67

Merged
jackdomleo7 merged 2 commits intomasterfrom
63_customise_attribute
Nov 11, 2021
Merged

Customise attribute the tooltip is bound to#67
jackdomleo7 merged 2 commits intomasterfrom
63_customise_attribute

Conversation

@jackdomleo7
Copy link
Owner

Enhancement/maintenance description

Why is this enhancement/maintenance important?

  • Some developers don't want to bind the tooltips to the aria-label attribute, so this gives them the option to change it
  • Resolves a bug in v2.x where Sass variables cannot actually be overridden

Did you test on all major browsers?

I couldn't test Safari because I don't have access to an Apple device.

  • Chrome
  • Firefox
  • Edge
  • Safari

Other details

N/A


T&Cs

  • I confirm I have read and understand the contributing guidelines
  • I understand the work in this pull request will not be released straight away and will appear in a future release (if approved)
  • I confirm the work in this pull request is true and valid to the best of my knowledge

@jackdomleo7 jackdomleo7 added the enhancement New feature or request label Nov 11, 2021
@jackdomleo7 jackdomleo7 self-assigned this Nov 11, 2021
@jackdomleo7 jackdomleo7 merged commit bb7b69b into master Nov 11, 2021
@jackdomleo7 jackdomleo7 deleted the 63_customise_attribute branch November 11, 2021 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: Can't override Sass !default variables in v2.0.0 [FEATURE]: Customisation of attribute the tooltip is bound to

1 participant