Skip to content

Made sass a peer dependency#137

Merged
jackdomleo7 merged 1 commit into
masterfrom
129_make_sass_a_peer_dependency
Oct 14, 2021
Merged

Made sass a peer dependency#137
jackdomleo7 merged 1 commit into
masterfrom
129_make_sass_a_peer_dependency

Conversation

@jackdomleo7

@jackdomleo7 jackdomleo7 commented Oct 14, 2021

Copy link
Copy Markdown
Owner

Enhancement/maintenance description

Why is this enhancement/maintenance important?

  • Lets developers know to use the Sass part of this project, they must install sass as a dependency

Covered test cases

Regression

Did you test on all major browsers?

I couldn't test Safari because I don't have access to an Apple device.

  • Chrome
  • Firefox
  • Edge
  • Safari

Other details

N/A


T&Cs

  • I confirm I have read and understand the contributing guidelines
  • I understand the work in this pull request will not be released straight away and will appear in a future release (if approved)
  • I confirm the work in this pull request is true and valid to the best of my knowledge
  • I have updated the README, features.md and codes.md files where applicable

@jackdomleo7 jackdomleo7 added the project enhancement Enhancement to improving the overall project label Oct 14, 2021
@jackdomleo7 jackdomleo7 self-assigned this Oct 14, 2021
@jackdomleo7 jackdomleo7 merged commit cbd1853 into master Oct 14, 2021
@jackdomleo7 jackdomleo7 deleted the 129_make_sass_a_peer_dependency branch October 14, 2021 20:11
@jackdomleo7 jackdomleo7 added this to the v2 milestone Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

project enhancement Enhancement to improving the overall project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ENHANCEMENT]: Make Sass a peerdependency

1 participant