Add new warnings for anchor tags that could link to non-a11y content#120
Merged
jackdomleo7 merged 11 commits intoOct 10, 2021
Merged
Add new warnings for anchor tags that could link to non-a11y content#120jackdomleo7 merged 11 commits into
jackdomleo7 merged 11 commits into
Conversation
jackdomleo7
approved these changes
Oct 10, 2021
Owner
There was a problem hiding this comment.
Really nice PR @tannerdolby! Can't fault anything at all. Good idea splitting the issue into 2 separate feature codes. Would be nice to see some screenshots though in the PR description for reference. 🙂
Contributor
Author
|
Thank you @jackdomleo7! Yeah, I thought the 2 separate feature codes would be best so I'm glad thats what you had in mind too. Ah, yes I forgot to do that in the first pass. I will add some screenshots from the cypress test UI into the PR description shortly for reference 📚 |
Contributor
Author
|
While I was grabbing the screenshots, I actually caught a small error in the test fixture |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creates two new warnings to address:
I wasn't sure if this was suppose to have an "Error" code created as well so we can add that here if needed. We could also add more file extensions and/or site URLs to make this more full proof but this is a good start! 🚀
Types of changes
Description
Fixes #109
/warnings/featured/_links.scsspartial file to address the possibility that a link contains a href containing a url of some content site (Youtube, Spotify etc) or a file (.pdf, .docx, .xls, etc).cypressfolderLink(s)
https://developer.mozilla.org/en-US/docs/Web/CSS/Attribute_selectors
Screenshot(s)
Checklist:
xif you have considered this but thought there was nothing to add or modify).contributorssection inpackage.json(still put anxif you have considered this but decided not to add yourself).test/index.htmlto thetest/index.htmlin themasterbranch).