Add warning for section not containing heading element (W0012)#115
Merged
Conversation
jackdomleo7
requested changes
Oct 7, 2021
jackdomleo7
left a comment
Owner
There was a problem hiding this comment.
Nice job here! Just one minor thing I'd like adding 🙂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
This feature adds a warning to a
<section>not containing heading element which it should be contained because a<section>doesn't has other specific semantic element to represent it. Resolves: #89Link(s)
Screenshot(s)
Checklist:
xif you have considered this but thought there was nothing to add or modify).contributorssection inpackage.json(still put anxif you have considered this but decided not to add yourself).test/index.htmlto thetest/index.htmlin themasterbranch).Help
I could not test in Safari because I do not have access to an Apple device.