Add debugging to PBRTerrainTests to troubleshoot rendering issue #2393
+109
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rendering issue This PR attempts to fix the issue that my previous PR unfortunately failed to fix: #2365 I have made some more minor changes to the shader code that might fix it. But I'm also going to update the PBRTerrain tests so users can easily toggle the DebugValuesMode debug view of each individual pbr layer so that issues like this are easier to troubleshoot in the future.
Member
Author
|
This PR will be merged in about 24 hours. This did not fix the bug unfortunately. but the debug updates to the pbr terrain examples will still be useful in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix the issue that my previous PR unfortunately failed to fix: #2365
I have made some more minor changes to the shader code that might fix it.
And shortly I'm also going to update this PR so that the PBRTerrain tests will allow users to easily toggle the DebugValuesMode debug view of each individual pbr layer so that issues like this are easier to troubleshoot in the future.