-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fixed for windows and linux hack for mac threading #1513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Please note, this exact change was already discussed and closed in PR #1048. |
|
Why was #1048 closed? |
|
It can be re-opened if people are interested. It was open for 6 months with no more feedback or interest in moving it forward. Would you like me to re-open it? |
|
Note from a quick glance PR #1048 is slightly different from this one. This PR checks the OS type and does not start a new thread if it is on Mac. |
|
But it's not really a Mac-specific issue if you follow the Glfw docs. It's a Glfw issue that magically/accidentally/may-break-someday happens to work on other platforms today. I'm also wary about adding "if this value contains one of these magic strings then guess that this might be MacOS today"... it's a maintenance nightmare as we add new strings for every new Mac release that might mess with that string. |
|
I personally think the check for if it is MacOS or not needs to be done at the application level and not within JME. EDIT: And as @pspeed42 stated, really jme should not fork the thread at all as per the glfw docs. |
Yes, I thought the code which broke the functionality was unnecessarily Draconian, affecting previous behavior on all OSs. The real solution would probably be test on Mac hardware, and figure out how to re-implement the original behavior. |
|
I worked around the issue pretty easily at the app level, and for me this issue could be closed. |
I believe the function was broken 5 years ago to "satisfy a Mac problem?" - it does not spawn a new asynchronous thread or obey the waitFor parameter as was originally intended.
I was not sure what to do, I don't have a Mac, so I put in a conditional - probably someone who has mac hardware could fix this the right case for the single use case.