Skip to content

Improve version resolution fast paths#94

Merged
j178 merged 2 commits into
mainfrom
feat/improve-version-resolution
Mar 16, 2026
Merged

Improve version resolution fast paths#94
j178 merged 2 commits into
mainfrom
feat/improve-version-resolution

Conversation

@j178

@j178 j178 commented Mar 16, 2026

Copy link
Copy Markdown
Owner

Summary

  • return exact versions directly even when the manifest has not caught up yet
  • shortcut simple lower-bound ranges to the latest stable manifest release
  • add coverage for the new fast paths and their failure cases

Testing

  • npm test

Copilot AI review requested due to automatic review settings March 16, 2026 06:44
@j178 j178 force-pushed the feat/improve-version-resolution branch from 8be67f7 to 0dd5203 Compare March 16, 2026 06:46

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8be67f7e32

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/manifest.ts Outdated

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates version resolution in src/manifest.ts to add faster paths for exact versions and simple lower-bound semver ranges, and adds/adjusts unit tests to cover the new behavior and failure cases.

Changes:

  • Allow exact semver inputs to resolve directly (without requiring presence in the bundled manifest).
  • Add a “simple lower-bound range” shortcut to resolve to the latest stable manifest release when appropriate.
  • Extend unit tests to cover the new fast paths and related error cases.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

File Description
src/manifest.ts Adds exact-version fast path and a helper to detect/shortcut simple lower-bound ranges to latest stable.
test/manifest.test.ts Adds tests for the new fast paths (including manifest-missing exact versions) and adjusts unsatisfied-range coverage.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/manifest.ts Outdated
Comment thread test/manifest.test.ts Outdated
@j178 j178 force-pushed the feat/improve-version-resolution branch from 311ca7e to 5f5a6f9 Compare March 16, 2026 07:18
@j178 j178 merged commit 1242fd6 into main Mar 16, 2026
9 checks passed
@j178 j178 deleted the feat/improve-version-resolution branch March 16, 2026 07:20
@j178 j178 added the enhancement New feature or request label Mar 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants