Reduce missing checksum log noise#117
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 92641e2851
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const result = await validateDownloadedChecksum(archivePath, asset, version) | ||
| if (result === 'missing') { | ||
| core.warning( | ||
| core.debug( |
There was a problem hiding this comment.
Preserve visibility when checksum verification is skipped
When knownChecksumsByAsset lacks an entry (e.g., for newly published versions), this path installs the binary without any integrity check; changing core.warning to core.debug hides that fact in normal GitHub Actions logs because debug output is off by default. In those cases users now get a “successful” install with no visible indication that verification was bypassed, which weakens supply-chain safety monitoring for CI runs.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Pull request overview
Reduces runner log noise in this GitHub Action by downgrading the “missing checksum; skipping verification” message from a warning to a debug-level log, while keeping the behavior (skip verification when no known checksum exists) unchanged.
Changes:
- Change missing-checksum logging in the installer from
warningtodebug. - Regenerate/commit the bundled output reflecting the same logging change.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/install.ts | Downgrades missing-checksum message from warning to debug during download verification. |
| dist/index.cjs | Bundled output updated to match the source logging change. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Closes #116