Migrate formatting to Biome#103
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR migrates repository formatting/linting from Prettier to Biome, updates CI to enforce the new checks, and applies the resulting formatting changes across source, tests, and scripts (including some minor process.env access cleanup in prek/cache handling).
Changes:
- Add
biome.json, replace Prettier with@biomejs/biome, and update npm scripts to run Biome in CI and locally. - Update CI workflow to run the action (“Prek”) and add a dedicated “Lint” job for Biome checks.
- Apply Biome-driven formatting/organize-imports changes across
src/,test/, andscripts/, plus simplify TS configincludeglobs.
Reviewed changes
Copilot reviewed 14 out of 19 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
biome.json |
Introduces Biome configuration (formatting + lint recommended rules + file scoping). |
package.json |
Replaces Prettier with Biome; updates/extends scripts (check-format, format). |
package-lock.json |
Locks new Biome dependency set; removes Prettier. |
.github/workflows/ci.yaml |
Adds Biome lint job and renames/keeps action run job; minor quoting updates. |
tsconfig.json |
Simplifies include to directory form; formatting. |
tsconfig.test.json |
Simplifies include to directory form; formatting. |
src/cache.ts |
Formatting + process.env access changes in cache key construction. |
src/install.ts |
Formatting + import ordering; no functional intent apparent. |
src/manifest.ts |
Formatting + import ordering; wraps long strings/throws for style. |
src/prek.ts |
Formatting + process.env access updates in cache-dir fallback logic. |
src/inputs.ts |
Formatting (imports/object trailing commas). |
src/main.ts |
Formatting (imports). |
src/post.ts |
Formatting (imports). |
src/types.ts |
Formatting (type spacing). |
scripts/update-known-versions.mjs |
Formatting and minor expression wrapping; no functional intent apparent. |
test/cache.test.ts |
Formatting + process.env access changes consistent with source updates. |
test/install.test.ts |
Formatting (imports/object literals). |
test/manifest.test.ts |
Formatting (imports/object literals/assert formatting). |
test/prek.test.ts |
Formatting + process.env access changes consistent with source updates. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ddacf48 to
46532d3
Compare
46532d3 to
7612333
Compare
Collaborator
|
Nice :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.