fix: use single space before frozen comment in YAML config#1944
Closed
Ai-chan-0411 wants to merge 1 commit into
Closed
fix: use single space before frozen comment in YAML config#1944Ai-chan-0411 wants to merge 1 commit into
Ai-chan-0411 wants to merge 1 commit into
Conversation
auto-update --freeze was adding 2 spaces before the `# frozen:` comment in YAML config files, which caused `prettier` (and other YAML formatters that enforce single-space before inline comments) to rewrite the line on the next hook run. Fixes j178#1941
Owner
|
Thanks, I think we should preserve the original spacing instead of fixed 1 space. I fixed it in #1945. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
# frozen:comment in YAML config outputrender_updated_yaml_config()function used" # frozen:"(two spaces) instead of" # frozen:"(one space), inconsistent with the TOML path which correctly uses single spaceDetails
In
auto_update.rs, the format string at the YAML frozen comment render had an extra leading space. The TOML path (render_updated_toml_config) already uses the correct single-space format.Fixes #1941
Test plan
🤖 Generated with Claude Code