Skip to content

Support language: unsupported and language: unsupported_script introduced in pre-commit v4.4#1073

Merged
j178 merged 2 commits into
masterfrom
compat-4.4
Nov 14, 2025
Merged

Support language: unsupported and language: unsupported_script introduced in pre-commit v4.4#1073
j178 merged 2 commits into
masterfrom
compat-4.4

Conversation

@j178

@j178 j178 commented Nov 14, 2025 •
edited
Loading

Copy link
Copy Markdown
Owner

Honestly, I have no idea why system and script got deprecated or what we're supposed to use instead. I probably won't deprecate them in prek.

Closes #1070

@j178
Support language: unsupported and language: unsupported_script in…
c78d7d2 
…troduced in pre-commit v4.4

Honestly, I have no idea why `system` and `script` got deprecated or what we're supposed to use instead. I probably won't deprecate them in prek.
@j178 j178 added the enhancement New feature or request label Nov 14, 2025
@codecov

codecov Bot commented Nov 14, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.82%. Comparing base (597ad58) to head (bd93fab).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1073      +/-   ##
==========================================
+ Coverage   89.75%   89.82%   +0.06%     
==========================================
  Files          72       72              
  Lines       13299    13299              
==========================================
+ Hits        11937    11946       +9     
+ Misses       1362     1353       -9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Nov 14, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

📦 Cargo Bloat Comparison

Binary size change: +0.00% (16.2 MiB → 16.2 MiB)

Expand for cargo-bloat output

Head Branch Results

 File  .text     Size          Crate Name
 0.6%   1.3% 101.3KiB          prek? <prek::cli::Command as clap_builder::derive::Subcommand>::augment_subcommands
 0.6%   1.3%  97.4KiB           prek prek::builtin::pre_commit_hooks::Implemented::run::{{closure}}
 0.6%   1.2%  94.2KiB           prek prek::languages::<impl prek::config::Language>::run::{{closure}}
 0.4%   1.0%  72.7KiB           prek prek::archive::unpack::{{closure}}
 0.3%   0.6%  48.8KiB           prek prek::run::{{closure}}
 0.2%   0.5%  40.0KiB           prek prek::languages::<impl prek::config::Language>::install::{{closure}}
 0.2%   0.5%  39.1KiB          prek? <prek::cli::RunArgs as clap_builder::derive::Args>::augment_args
 0.2%   0.5%  37.3KiB regex_automata regex_automata::meta::strategy::new
 0.2%   0.4%  32.5KiB             h2 h2::proto::connection::Connection<T,P,B>::poll
 0.2%   0.4%  32.3KiB           prek prek::languages::node::installer::NodeInstaller::install::{{closure}}
 0.2%   0.4%  31.9KiB             h2 h2::proto::connection::DynConnection<B>::recv_frame
 0.2%   0.4%  31.5KiB           prek prek::workspace::Workspace::discover
 0.2%   0.4%  30.7KiB           prek prek::cli::run::run::run::{{closure}}
 0.2%   0.4%  27.6KiB           prek prek::identify::by_extension::{{closure}}
 0.2%   0.3%  25.4KiB     hyper_util hyper_util::client::legacy::client::Client<C,B>::connect_to::{{closure}}::{{closure}}::{{closure}}
 0.2%   0.3%  25.1KiB           prek prek::main
 0.1%   0.3%  24.8KiB     hyper_util hyper_util::client::legacy::client::Client<C,B>::send_request::{{closure}}
 0.1%   0.3%  24.8KiB           prek prek::hook::HookBuilder::build::{{closure}}
 0.1%   0.3%  24.2KiB           prek prek::languages::golang::installer::GoInstaller::install::{{closure}}
 0.1%   0.3%  23.9KiB          hyper hyper::proto::h1::dispatch::Dispatcher<D,Bs,I,T>::poll_loop
39.9%  87.6%   6.5MiB                And 10187 smaller methods. Use -n N to show more.
45.6% 100.0%   7.4MiB                .text section size, the file size is 16.2MiB

Base Branch Results

 File  .text     Size          Crate Name
 0.6%   1.3% 101.3KiB          prek? <prek::cli::Command as clap_builder::derive::Subcommand>::augment_subcommands
 0.6%   1.3%  97.4KiB           prek prek::builtin::pre_commit_hooks::Implemented::run::{{closure}}
 0.6%   1.2%  94.2KiB           prek prek::languages::<impl prek::config::Language>::run::{{closure}}
 0.4%   1.0%  72.7KiB           prek prek::archive::unpack::{{closure}}
 0.3%   0.6%  48.8KiB           prek prek::run::{{closure}}
 0.2%   0.5%  40.0KiB           prek prek::languages::<impl prek::config::Language>::install::{{closure}}
 0.2%   0.5%  39.1KiB          prek? <prek::cli::RunArgs as clap_builder::derive::Args>::augment_args
 0.2%   0.5%  37.3KiB regex_automata regex_automata::meta::strategy::new
 0.2%   0.4%  32.5KiB             h2 h2::proto::connection::Connection<T,P,B>::poll
 0.2%   0.4%  32.3KiB           prek prek::languages::node::installer::NodeInstaller::install::{{closure}}
 0.2%   0.4%  31.9KiB             h2 h2::proto::connection::DynConnection<B>::recv_frame
 0.2%   0.4%  31.5KiB           prek prek::workspace::Workspace::discover
 0.2%   0.4%  30.7KiB           prek prek::cli::run::run::run::{{closure}}
 0.2%   0.4%  27.6KiB           prek prek::identify::by_extension::{{closure}}
 0.2%   0.3%  25.4KiB     hyper_util hyper_util::client::legacy::client::Client<C,B>::connect_to::{{closure}}::{{closure}}::{{closure}}
 0.2%   0.3%  25.1KiB           prek prek::main
 0.1%   0.3%  24.8KiB     hyper_util hyper_util::client::legacy::client::Client<C,B>::send_request::{{closure}}
 0.1%   0.3%  24.8KiB           prek prek::hook::HookBuilder::build::{{closure}}
 0.1%   0.3%  24.2KiB           prek prek::languages::golang::installer::GoInstaller::install::{{closure}}
 0.1%   0.3%  23.9KiB          hyper hyper::proto::h1::dispatch::Dispatcher<D,Bs,I,T>::poll_loop
39.9%  87.6%   6.5MiB                And 10187 smaller methods. Use -n N to show more.
45.6% 100.0%   7.4MiB                .text section size, the file size is 16.2MiB

@j178 j178 merged commit e672f83 into master Nov 14, 2025
21 checks passed
@j178 j178 deleted the compat-4.4 branch November 14, 2025 07:53
@BrewTestBot BrewTestBot mentioned this pull request Nov 14, 2025
Merged
@nathanjmcdougall

nathanjmcdougall commented Nov 14, 2025

Copy link
Copy Markdown
Contributor

@j178

I have no idea why system and script got deprecated or what we're supposed to use instead.

I think the motivation is basically that the name is misleading - language: system implies there's a language supported by pre-commit called system, whereas really this is an escape hatch, and there's no language management features at all. Likewise, for language: script, it could be misinterpreted. I'm guessing the folks working on pre-commit were getting a lot of support requests from people misunderstanding the degree to which language: system should "just work" out of the box.

To be clear, the deprecation only applies to the name used for this config. There's no plan to deprecate the new language: unsupported and language: unsupported_script specifiers.

The irony here is that the new names are probably misleading too! They imply that those two options are themselves going to be deprecated at some point in the future.

Regardless of the motivations, I would personally support that in prek you avoid breaking backward compatibility over a naming issue.

@j178

j178 commented Nov 15, 2025

Copy link
Copy Markdown
Owner Author

To be clear, the deprecation only applies to the name used for this config. There's no plan to deprecate the new language: unsupported and language: unsupported_script specifiers.

Thanks, that makes more sense now.

@wookie184 wookie184 mentioned this pull request Dec 17, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

language: unsupported and unsupported_script are not supported

2 participants

@j178 @nathanjmcdougall