*_allocator<void>: Make members public#586
Closed
roberth wants to merge 1 commit intobdwgc:masterfrom
Closed
Conversation
Member
|
Agree. But I think same should be done for gc_allocator and gc_allocator_ignore_off_page |
A private value_type is a problem for boost small_vector<X>, which
instantiates rebind<void> at some point.
For example, instantiating small_vector<int, 8, traceable_allocator<int>> results in:
include/boost/container/allocator_traits.hpp:145:37: error: 'value_type' is a private member of 'traceable_allocator<void>'
typedef typename allocator_type::value_type value_type;
[...]
gc_allocator.h:319:23: note: implicitly declared private here
typedef void value_type;
I don't see a reason why any of the members should be private, and
arguably it violates the Liskov substitution principle. It seems that
it was left private by accidental omission.
1efa161 to
86f63fb
Compare
Contributor
Author
|
Good point; done. Perhaps superfluously, I think the CI failures are unrelated (no C++ involved) and flaky (went from 4 to 2 failures for no apparent reason) |
ivmai
pushed a commit
that referenced
this pull request
Nov 27, 2023
PR #586 (bdwgc). A private value_type is a problem for boost small_vector<X>, which instantiates rebind<void> at some point. E.g., instantiating small_vector<int, 8, traceable_allocator<int>> results in "'value_type' is a private member of 'traceable_allocator<void>'" compiler error. I don't see a reason why any of the members should be private, and arguably it violates the Liskov substitution principle. It seems that these were left private by an accidental omission. * include/gc/gc_allocator.h (gc_allocator<void>, gc_allocator_ignore_off_page<void>, traceable_allocator<void>): Declare all members of the class as public.
Member
|
Merged |
Contributor
Author
|
Thanks! |
ivmai
pushed a commit
that referenced
this pull request
Dec 14, 2023
(a cherry-pick of commit 86b3bf0 from 'master') PR #586 (bdwgc). A private value_type is a problem for boost small_vector<X>, which instantiates rebind<void> at some point. E.g., instantiating small_vector<int, 8, traceable_allocator<int>> results in "'value_type' is a private member of 'traceable_allocator<void>'" compiler error. I don't see a reason why any of the members should be private, and arguably it violates the Liskov substitution principle. It seems that these were left private by an accidental omission. * include/gc_allocator.h (gc_allocator<void>, gc_allocator_ignore_off_page<void>, traceable_allocator<void>): Declare all members of the class as public.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A private value_type is a problem for boost small_vector, which instantiates rebind at some point.
[...]
I don't see a reason why any of the members should be private, and arguably it violates the Liskov substitution principle. It seems that it was left private by accidental omission.