Conversation
Owner
|
I will go ahead and merge it first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
sp_sizeandsp_rankin model runner args.input_ids, it reorders them by[req_0_sp_0, req_1_sp_0, ..., req_n_sp_0, req_1_sp_1, ...]. In this way, when switching to the sequence parallel, there only needs anAllGatherbut no re-indexing.Generally, we have 3 layouts for tokens:
[req_1, req_2, ...][req_1_sp_0, req_2_sp_0, ... req_n_sp_0, req_1_sp_1, ...];#tokens(req) % sp_size != 0, the first few sequence parallel ranks will have more tokens. To make operations like AllGather easy, other sequence parallel ranks are padded. This one looks like:Here we write it as if it's a 2D matrix, but it's actually 1-D. For each SP rank, padding is only added at the end (instead of at every req's end).