Fix parsing of underlined headers#411
Conversation
| /** We are outside any specification item */ | ||
| OUTSIDE, |
There was a problem hiding this comment.
Replaced with START to simplify state machines
There was a problem hiding this comment.
Sure that there was no transition between start and outside? When the first line was hit?
I must admit I forgot why I introduced that. Too long ago.
There was a problem hiding this comment.
The behavior of START and OUTSIDE was the same. And tests are still green ;)
| /** We are outside any specification item */ | ||
| OUTSIDE, |
There was a problem hiding this comment.
Sure that there was no transition between start and outside? When the first line was hit?
I must admit I forgot why I introduced that. Too long ago.
| static Stream<Arguments> testCases() | ||
| { | ||
| return Stream.of( | ||
| testCase(null, null, null), |
There was a problem hiding this comment.
You could define TITLE_NOT_RECOGNIZED as null to make the test definition clearer. Similar in other cases.
There was a problem hiding this comment.
Now I use a separate method titleNotRecongnized to avoid repeating the parameter ;)
| .description("Item 1 description") | ||
| .location("file", 2 + titleLocationOffset) | ||
| .build(), | ||
| item().id(SpecificationItemId.createId("req", "item2", 1)) |
There was a problem hiding this comment.
👍 Good test!
Indentation looks strange, though.
There was a problem hiding this comment.
The formatter did it ;) Is it better now?
|
No description provided.