260 Aspec Reporter#261
Merged
Merged
Conversation
added 16 commits
February 6, 2021 17:36
… copy of the Specobject exporter. No tests yet.
…ature/aspec_reporter
…verCoveredAttributeTypes within addLinkToItemWithStatus. Removed mthods to update coveredAttributeTypes and overCoveredAttributeTypes from outside. Updated related test. Added getCoveredApprovedAttributeTypes(). Added isCoveredShallowWithApprovedItems(). Added getDeepCoverageStatusOnlyAcceptApprovedItems().
…pport to only considered approved requirement for coverage.
… output for asserts.
…o provide coverred shallow and transient coverage honouring item status.
…atus proposed froviding no coverae.
…testsupport for covering status
added 10 commits
April 26, 2021 21:57
…ddLinkToItemWithStatus if they are missing
Contributor
Author
|
@redcatbear , @kaklakariada please review |
kaklakariada
reviewed
May 2, 2021
kaklakariada
approved these changes
May 2, 2021
kaklakariada
left a comment
Contributor
There was a problem hiding this comment.
Looks great, thank you for your changes!
Please still wait for @redcatbear 's review.
redcatbear
requested changes
May 9, 2021
redcatbear
left a comment
Collaborator
There was a problem hiding this comment.
First review. Until mid of user_guide.md.
Co-authored-by: Sebastian Bär <redcatbear@ursus-minor.de>
Co-authored-by: Sebastian Bär <redcatbear@ursus-minor.de>
Co-authored-by: Sebastian Bär <redcatbear@ursus-minor.de>
Co-authored-by: Sebastian Bär <redcatbear@ursus-minor.de>
Co-authored-by: Sebastian Bär <redcatbear@ursus-minor.de>
Co-authored-by: Sebastian Bär <redcatbear@ursus-minor.de>
Co-authored-by: Sebastian Bär <redcatbear@ursus-minor.de>
Co-authored-by: Sebastian Bär <redcatbear@ursus-minor.de>
Co-authored-by: Sebastian Bär <redcatbear@ursus-minor.de>
|
Kudos, SonarCloud Quality Gate passed! |
added 6 commits
May 11, 2021 23:01
…enfasttrace into feature/260-aspec_reporter
…ave a documentation).
redcatbear
requested changes
May 16, 2021
| private DeepCoverageStatus adjustDeepCoverageStatusIfApprovedRequired(boolean onlyAcceptApprovedItemStatus, | ||
| DeepCoverageStatus deepCoveredStatus) | ||
| { | ||
| if (onlyAcceptApprovedItemStatus && deepCoveredStatus == DeepCoverageStatus.COVERED && !isApproved()) |
Collaborator
There was a problem hiding this comment.
I like the method as such.
To keep things final, please replace if by return statement using the ? operator. This way the parameters don't need to be modified.
Comment on lines
+105
to
+116
| writer.writeStartDocument( "UTF-8", "1.0" ); | ||
| writer.writeStartElement( "specdocument" ); | ||
|
|
||
| for( final Map.Entry<String, List<LinkedSpecificationItem>> entry : items.entrySet() ) | ||
| { | ||
| final String doctype = entry.getKey(); | ||
| final List<LinkedSpecificationItem> specItems = entry.getValue(); | ||
| writeItems( writer, doctype, specItems ); | ||
| } | ||
|
|
||
| writer.writeEndElement(); | ||
| writer.writeEndDocument(); |
Collaborator
There was a problem hiding this comment.
Suggested change
| writer.writeStartDocument( "UTF-8", "1.0" ); | |
| writer.writeStartElement( "specdocument" ); | |
| for( final Map.Entry<String, List<LinkedSpecificationItem>> entry : items.entrySet() ) | |
| { | |
| final String doctype = entry.getKey(); | |
| final List<LinkedSpecificationItem> specItems = entry.getValue(); | |
| writeItems( writer, doctype, specItems ); | |
| } | |
| writer.writeEndElement(); | |
| writer.writeEndDocument(); | |
| writer.writeStartDocument( "UTF-8", "1.0" ); | |
| writer.writeStartElement( "specdocument" ); | |
| for( final Map.Entry<String, List<LinkedSpecificationItem>> entry : items.entrySet() ) | |
| { | |
| final String doctype = entry.getKey(); | |
| final List<LinkedSpecificationItem> specItems = entry.getValue(); | |
| writeItems( writer, doctype, specItems ); | |
| } | |
| writer.writeEndElement(); | |
| writer.writeEndDocument(); |
Collaborator
There was a problem hiding this comment.
Extract for loop to method.
| final IndentingXMLStreamWriter indentingXmlWriter = new IndentingXMLStreamWriter( xmlWriter ); | ||
| final Map<String, List<LinkedSpecificationItem>> items = groupByDoctype( this.trace.getItems().stream() ); | ||
|
|
||
| LOG.info( "aspec starting" ); |
Collaborator
There was a problem hiding this comment.
On log level INFO you should be a bit more specific. :-)
Remember, this is the default level, so users will always see this.
Otherwise adhere to E. S. Raymond's rule of silence: "If an application has nothing interesting to say, it should say nothing." :-)
Contributor
Author
There was a problem hiding this comment.
This is a tracing message. Change to fine()
| writer.writeEndElement(); | ||
| } | ||
|
|
||
| private void writeItem( final XMLStreamWriter writer, final LinkedSpecificationItem item ) throws XMLStreamException |
Collaborator
There was a problem hiding this comment.
Please split this method into section by extracting cohesive parts to methods with speaking names.
Comment on lines
+215
to
+230
| if( linkStatus == LinkStatus.COVERED_SHALLOW && deepCoverageStatus == DeepCoverageStatus.COVERED ) | ||
| { | ||
| writeElement( writer, "coveringStatus", CoveringStatus.COVERING.getLabel() ); | ||
| } | ||
| else if( linkStatus == LinkStatus.COVERED_SHALLOW ) | ||
| { | ||
| writeElement( writer, "coveringStatus", CoveringStatus.UNCOVERED.getLabel() ); | ||
| } | ||
| else if( linkStatus == LinkStatus.COVERED_PREDATED || linkStatus == LinkStatus.COVERED_OUTDATED ) | ||
| { | ||
| writeElement( writer, "coveringStatus", CoveringStatus.OUTDATED.getLabel() ); | ||
| } | ||
| else if( linkStatus == LinkStatus.AMBIGUOUS || linkStatus == LinkStatus.COVERED_UNWANTED ) | ||
| { | ||
| writeElement( writer, "coveringStatus", CoveringStatus.UNEXPECTED.getLabel() ); | ||
| } |
redcatbear
approved these changes
May 23, 2021
redcatbear
left a comment
Collaborator
There was a problem hiding this comment.
Approved with one minor change left.
…SpecificationItem.java Co-authored-by: Sebastian Bär <redcatbear@ursus-minor.de>
|
Kudos, SonarCloud Quality Gate passed! |
redcatbear
approved these changes
May 24, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Aspec Report is a new reporter with name "apec" that reports all items and their coverage and linkage as XML file so that that tracing renerated by openfasttrace can be processed by other tools.
Closes #260