Report payload launch failures

owendswang · owendswang · commit 38b112496eb8 · 2026-05-28T02:48:01.000+08:00
diff --git a/src/main.c b/src/main.c
@@ -731,6 +731,7 @@ static enum MHD_Result on_request(void *cls, struct MHD_Connection *conn,
 
   struct MHD_Response *resp = NULL;
   enum MHD_Result ret;
+  int http_status = MHD_HTTP_OK;
 
   if (strcmp(url, ROUTE_USB_MOVE_CHECK) == 0) {
     const char *path = MHD_lookup_connection_value(conn, MHD_GET_ARGUMENT_KIND, "path");
@@ -922,16 +923,19 @@ static enum MHD_Result on_request(void *cls, struct MHD_Connection *conn,
     }
 
     if (!final_path) {
+      pldmgr_log("[PLDMGR] !!! Payload path rejected: %s\n", path);
       const char *err = "Invalid payload name\n";
       resp = MHD_create_response_from_buffer(strlen(err), (void *)err,
                                              MHD_RESPMEM_PERSISTENT);
+      http_status = MHD_HTTP_BAD_REQUEST;
     } else if (ps5_launch_elf(final_path) == 0) {
       resp = MHD_create_response_from_buffer(strlen(MSG_OK), (void *)MSG_OK,
                                              MHD_RESPMEM_PERSISTENT);
     } else {
       const char *err = "Failed to launch payload\n";
       resp = MHD_create_response_from_buffer(strlen(err), (void *)err,
                                              MHD_RESPMEM_PERSISTENT);
+      http_status = MHD_HTTP_INTERNAL_SERVER_ERROR;
     }
     MHD_add_response_header(resp, "Content-Type", "text/plain");
   } else if (strncmp(url, ROUTE_DELETE, strlen(ROUTE_DELETE)) == 0) {
@@ -1134,7 +1138,7 @@ static enum MHD_Result on_request(void *cls, struct MHD_Connection *conn,
   /* Add CORS headers */
   add_cors_headers(resp);
 
-  ret = MHD_queue_response(conn, MHD_HTTP_OK, resp);
+  ret = MHD_queue_response(conn, http_status, resp);
   MHD_destroy_response(resp);
 
   return ret;
diff --git a/src/ps5_launcher.c b/src/ps5_launcher.c
@@ -54,20 +54,33 @@ int ps5_launch_elf(const char *path) {
   /* Stream the file */
   char buffer[8192];
   ssize_t read_bytes;
+  int error = 0;
   while ((read_bytes = read(fd, buffer, sizeof(buffer))) > 0) {
-    ssize_t sent = send(sock, buffer, read_bytes, 0);
-    if (sent < 0) {
-      perror("send");
-      break;
+    size_t offset = 0;
+    while (offset < (size_t)read_bytes) {
+      ssize_t sent = send(sock, buffer + offset, (size_t)read_bytes - offset, 0);
+      if (sent <= 0) {
+        pldmgr_log("[PLDMGR] !!! send failed while launching payload\n");
+        error = 1;
+        break;
+      }
+      offset += (size_t)sent;
+      total_sent += (size_t)sent;
     }
-    total_sent += sent;
+    if (error)
+      break;
+  }
+
+  if (read_bytes < 0) {
+    pldmgr_log("[PLDMGR] !!! read failed while launching payload\n");
+    error = 1;
   }
 
   pldmgr_log("[PLDMGR] Sent %zu bytes to loader.\n", total_sent);
 
   close(sock);
   close(fd);
-  return 0;
+  return error ? -1 : 0;
 }
 
 extern int sceSystemServiceLaunchWebBrowser(const char *uri);
