Skip alpn rewrite if alpnOverride filter metadata is false#4783
Merged
istio-testing merged 1 commit intoistio:masterfrom Aug 1, 2023
Merged
Skip alpn rewrite if alpnOverride filter metadata is false#4783istio-testing merged 1 commit intoistio:masterfrom
istio-testing merged 1 commit intoistio:masterfrom
Conversation
|
😊 Welcome @ksubrmnn! This is either your first contribution to the Istio proxy repo, or it's been You can learn more about the Istio working groups, code of conduct, and contributing guidelines Thanks for contributing! Courtesy of your friendly welcome wagon. |
Contributor
Author
howardjohn
reviewed
Jul 6, 2023
Member
howardjohn
left a comment
There was a problem hiding this comment.
conceptually lgtm but I am not an expert on this code so I won't/can't approve
cc @kyessenov
kyessenov
reviewed
Jul 6, 2023
| } | ||
|
|
||
| Http::FilterHeadersStatus AlpnFilter::decodeHeaders(Http::RequestHeaderMap&, bool) { | ||
| auto upstream_info = decoder_callbacks_->streamInfo().upstreamInfo(); |
kyessenov
reviewed
Jul 6, 2023
Contributor
kyessenov
left a comment
There was a problem hiding this comment.
Looks fine, can you add a test?
Contributor
|
asan is a flake, you can ignore stackdriver test failures |
Contributor
|
Part of istio/istio#40680 |
howardjohn
approved these changes
Jul 27, 2023
jewertow
reviewed
Jul 28, 2023
Signed-off-by: Kalya Subramanian <kasubra@microsoft.com>
hzxuzhonghu
approved these changes
Aug 1, 2023
zirain
approved these changes
Aug 1, 2023
Member
|
/test test-asan |
1 similar comment
Member
|
/test test-asan |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Skips alpn header rewrite if alpnOverride filter metadata is false. This metadata is set by Istio when TLS mode is simple.
Works with istio/istio#44918
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Partially solves istio/istio#40680
Special notes for your reviewer:
Please read the RFC for the design details
Can I get a pointer for where/how to add a test?