Merged
Conversation
switched envoy commit to fork with L7 PEP changes testing wrong SHA added internal listener and transport_socket
Change-Id: I80a834b7b995973ead80f3f1e1e8e795ca95c4a5
Use new envoy
* telemetry: add workload_metadata filter This PR is intended to establish a basic framework for a Listener filter that will be used to lookup client/server metadata for workload instances. If metadata can be found (based on IP addresses), the metadata will be written into FilterState, where it can be exploited by subsequent filters (for reporting, protocol encoding, etc.). It is expected that this filter will need to undergo significant modification as we flesh out the implementation (and relationship to other filters in the chain). For instance, ECDS support will need to be added. * update to match control plane PR * add support for baggage generation * fix errors from clang-format * address code review comments * clean up consts, etc.
Change-Id: I2cc0960342f2e7e0d48b69f4bdf85db78cbcdbaf
Signed-off-by: Yuchen Dai <lambdai@google.com> Change-Id: I84d69936b4bdaf10a0e325e2d64d1a074be6fd1d
Change-Id: I36d6ff42d9d8c397e015b4d8647b277662b5c6cb
Change-Id: Ib528be1d24609422afc5d66ca2d66b38eaabff8c
Change-Id: Ia08f1498d10ccba0677409a1a2c55367eb3f912d
Change-Id: Ibceaa1a916cd4236021643088c6f5feb2f468f8a
rebase ambient changes on envoy main
add baggage to dynamic metadata
This PR creates a new HTTP filter that is intended to live in the inbound_CONNECT_terminate chain. It will take the received baggage header and build a WorkloadMetadataObject filter state object to match. This filter state object can then be passed to the internal listener chain for processing by a subsequent filter that can (a) set the SSL connection info appropriately and (b) create a PeerInfo CEL filter state object for use in the stats filter. It is modeled after the header_to_metadata filter. If/once this is working, it can be likewise expanded to be a more general purpose (if warranted).
switched envoy commit to fork with L7 PEP changes testing wrong SHA added internal listener and transport_socket
Change-Id: I80a834b7b995973ead80f3f1e1e8e795ca95c4a5
* telemetry: add workload_metadata filter This PR is intended to establish a basic framework for a Listener filter that will be used to lookup client/server metadata for workload instances. If metadata can be found (based on IP addresses), the metadata will be written into FilterState, where it can be exploited by subsequent filters (for reporting, protocol encoding, etc.). It is expected that this filter will need to undergo significant modification as we flesh out the implementation (and relationship to other filters in the chain). For instance, ECDS support will need to be added. * update to match control plane PR * add support for baggage generation * fix errors from clang-format * address code review comments * clean up consts, etc.
Change-Id: I2cc0960342f2e7e0d48b69f4bdf85db78cbcdbaf
Signed-off-by: Yuchen Dai <lambdai@google.com> Change-Id: I84d69936b4bdaf10a0e325e2d64d1a074be6fd1d
Change-Id: I36d6ff42d9d8c397e015b4d8647b277662b5c6cb
Change-Id: Ib528be1d24609422afc5d66ca2d66b38eaabff8c
Change-Id: Ia08f1498d10ccba0677409a1a2c55367eb3f912d
Signed-off-by: Kuat Yessenov <kuat@google.com>
Set filter state with baggage from header
Added uProxy metadata mode
TLS passthrough, add h2 and TLS to CONNECT test
half-close fix
rename ambient components
Contributor
|
Should we add a new file somewhere with a TODO list of things that need to be addressed for ambient extensions (and filter state objects)? I feel like we would ultimately want some coherent scheme for namespacing, etc., as part of this, but I'm not sure that list of things lives anywhere outside our heads. |
Signed-off-by: Kuat Yessenov <kuat@google.com>
Contributor
Author
|
@douglas-reid we should have a follow up that puts them into proper hierarchy |
Contributor
|
As long as that work is being tracked somewhere, I'm fine with it. There are changes in this PR to the extensions used in Istio Classic ™️. They seem harmless, but I just want to note there is the potential for some impact. |
douglas-reid
approved these changes
Sep 13, 2022
Contributor
Author
|
Yeah, I checked stats and common changes, and they look harmless. Would be great if someone else takes a look. |
3ecf84c to
96a67d1
Compare
Contributor
Author
|
/retest |
2 similar comments
Contributor
Author
|
/retest |
Contributor
Author
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds extensions from the ambient branch. They don't matter on the data plane unless used by the control plane.