Skip to content

Update envoy-wasm sha#2559

Merged
istio-testing merged 6 commits intoistio:masterfrom
lizan:wasm_als_master
Nov 15, 2019
Merged

Update envoy-wasm sha#2559
istio-testing merged 6 commits intoistio:masterfrom
lizan:wasm_als_master

Conversation

@lizan
Copy link
Copy Markdown
Contributor

@lizan lizan commented Nov 13, 2019

Signed-off-by: Lizan Zhou lizan@tetrate.io

None

@lizan
Update envoy-wasm sha
94db81c 
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
@lizan lizan requested a review from a team November 13, 2019 20:19
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Nov 13, 2019
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 13, 2019
@istio-testing istio-testing added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 13, 2019
@lizan lizan requested a review from jplevyak November 13, 2019 21:40
@lizan
Copy link
Copy Markdown
Contributor Author

lizan commented Nov 13, 2019

@jplevyak PTAL this is mostly fixing changes by envoyproxy/envoy-wasm#274

@lizan
remove compile db
2a3edf3 
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
@istio-testing istio-testing added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 13, 2019
@lizan
fix for envoyproxy/envoy-wasm#216
682633f 
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
@istio-testing istio-testing added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 13, 2019
@lizan
Copy link
Copy Markdown
Contributor Author

lizan commented Nov 13, 2019

/retest

1 similar comment
@lizan
Copy link
Copy Markdown
Contributor Author

lizan commented Nov 14, 2019

/retest

@lizan
Copy link
Copy Markdown
Contributor Author

lizan commented Nov 14, 2019

@PiotrSikora ASAN is RBE timeout, what's the RBE cluster setting we're using?

@lizan
Copy link
Copy Markdown
Contributor Author

lizan commented Nov 14, 2019

/retest

@PiotrSikora
Copy link
Copy Markdown
Contributor

PiotrSikora commented Nov 14, 2019

I don't think there are any settings on the RBE side other than number of instances and their type?

@lizan
Copy link
Copy Markdown
Contributor Author

lizan commented Nov 15, 2019

@PiotrSikora I'm talking about the machine type, envoy-ci is on n2-standard-2 FYI

@lizan
roll forward
a1988b9 
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Nov 15, 2019 •
edited
Loading

@lizan: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/proxy-presubmit-asan.sh 682633f link /test proxy-presubmit-asan
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lizan
Copy link
Copy Markdown
Contributor Author

lizan commented Nov 15, 2019

/retest

@lizan lizan requested a review from PiotrSikora November 15, 2019 09:46
yxue
yxue reviewed Nov 15, 2019
View reviewed changes
.bazelrc
# Overrides workspace_status_command
build --workspace_status_command=tools/bazel_get_workspace_status

build:remote --remote_timeout=7200
Copy link
Copy Markdown
Member

@yxue yxue Nov 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this for?

Copy link
Copy Markdown
Contributor Author

@lizan lizan Nov 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without this RBE will timeout for wee8 build, because istio-testing is using different type of machine than upstream.

yxue
yxue approved these changes Nov 15, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@yxue yxue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@istio-testing istio-testing merged commit 73b18ca into istio:master Nov 15, 2019
@lizan lizan deleted the wasm_als_master branch November 15, 2019 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jplevyak jplevyak Awaiting requested review from jplevyak

@PiotrSikora PiotrSikora Awaiting requested review from PiotrSikora

1 more reviewer

@yxue yxue yxue approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lizan @PiotrSikora @istio-testing @yxue @googlebot