Skip to content

Always use Bazel-0.22 for macOS on CircleCI (release-1.1).#2282

Merged
duderino merged 1 commit intoistio:release-1.1from
PiotrSikora:bazel_macos-release-1.1
Jul 23, 2019
Merged

Always use Bazel-0.22 for macOS on CircleCI (release-1.1).#2282
duderino merged 1 commit intoistio:release-1.1from
PiotrSikora:bazel_macos-release-1.1

Conversation

@PiotrSikora
Copy link
Copy Markdown
Contributor

Backported from #2252.

Signed-off-by: Piotr Sikora piotrsikora@google.com

Backported from istio#2252.

Signed-off-by: Piotr Sikora <piotrsikora@google.com>
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Jun 20, 2019
@istio-testing istio-testing requested review from linsun and yxue June 20, 2019 03:06
@PiotrSikora PiotrSikora force-pushed the bazel_macos-release-1.1 branch from af6e077 to 2534f37 Compare June 20, 2019 03:15
Copy link
Copy Markdown
Contributor

@bianpengyuan bianpengyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@yxue
Copy link
Copy Markdown
Member

yxue commented Jun 20, 2019

/lgtm
/approve

@istio-testing
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bianpengyuan, crazyxy, PiotrSikora

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@PiotrSikora
Copy link
Copy Markdown
Contributor Author

@duderino ping.

@duderino duderino merged commit 70434c5 into istio:release-1.1 Jul 23, 2019
@duderino
Copy link
Copy Markdown

Thanks @PiotrSikora

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants