Skip to content

Update Envoy SHA to latest with option to select WASM runtimes.#2273

Merged
istio-testing merged 1 commit intoistio:masterfrom
PiotrSikora:envoy_72ac3212
Jun 13, 2019
Merged

Update Envoy SHA to latest with option to select WASM runtimes.#2273
istio-testing merged 1 commit intoistio:masterfrom
PiotrSikora:envoy_72ac3212

Conversation

@PiotrSikora
Copy link
Copy Markdown
Contributor

Signed-off-by: Piotr Sikora piotrsikora@google.com

Signed-off-by: Piotr Sikora <piotrsikora@google.com>
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Jun 13, 2019
@istio-testing istio-testing requested a review from utka June 13, 2019 20:50
Copy link
Copy Markdown
Contributor

@bianpengyuan bianpengyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@PiotrSikora
Copy link
Copy Markdown
Contributor Author

Sigh, it doesn't look like Prow jobs are even running...

/test proxy-presubmit

@PiotrSikora
Copy link
Copy Markdown
Contributor Author

I'm pretty sure that Prow is busted and Bazel is crashing, since logs are cut mid-build without any errors. cc @utka

@yxue
Copy link
Copy Markdown
Member

yxue commented Jun 13, 2019

/lgtm
/approve

@utka
Copy link
Copy Markdown
Contributor

utka commented Jun 13, 2019

it's passed jus tslow

@yxue yxue removed the approved label Jun 13, 2019
@PiotrSikora
Copy link
Copy Markdown
Contributor Author

Build timed out, take 3...

/test proxy-presubmit

@yxue
Copy link
Copy Markdown
Member

yxue commented Jun 13, 2019

/approve

@istio-testing
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bianpengyuan, crazyxy, PiotrSikora

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants