Skip to content

Use envoy-wasm as upstream#2231

Closed
bianpengyuan wants to merge 6 commits intoistio:masterfrom
bianpengyuan:test-wasm
Closed

Use envoy-wasm as upstream#2231
bianpengyuan wants to merge 6 commits intoistio:masterfrom
bianpengyuan:test-wasm

Conversation

@bianpengyuan
Copy link
Copy Markdown
Contributor

@bianpengyuan bianpengyuan commented May 23, 2019

No description provided.

@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label May 23, 2019
@bianpengyuan bianpengyuan mentioned this pull request May 23, 2019
Merged
@bianpengyuan
Copy link
Copy Markdown
Contributor Author

bianpengyuan commented May 23, 2019

/retest

2 similar comments
@bianpengyuan
Copy link
Copy Markdown
Contributor Author

bianpengyuan commented May 24, 2019

/retest

@bianpengyuan
Copy link
Copy Markdown
Contributor Author

bianpengyuan commented May 24, 2019

/retest

@bianpengyuan bianpengyuan reopened this May 24, 2019
@bianpengyuan bianpengyuan mentioned this pull request May 29, 2019
Closed
@bianpengyuan bianpengyuan changed the title [do not merge] test envoy build on prow Use envoy-wasm as upstream May 31, 2019
kyessenov
kyessenov reviewed May 31, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@kyessenov kyessenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented May 31, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bianpengyuan, kyessenov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bianpengyuan
Copy link
Copy Markdown
Contributor Author

bianpengyuan commented May 31, 2019

@kyessenov Seems like prow overlooks your approve?

@kyessenov kyessenov removed the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label May 31, 2019
@kyessenov kyessenov added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label May 31, 2019
@kyessenov
Copy link
Copy Markdown
Contributor

kyessenov commented May 31, 2019

@utka any hints how to kick tide to re-process this PR? it seems like it missed some success notifications from circle and cla bots.

@bianpengyuan
Copy link
Copy Markdown
Contributor Author

bianpengyuan commented May 31, 2019

I can recreate one if that is easier.

@kyessenov kyessenov closed this May 31, 2019
@kyessenov kyessenov reopened this May 31, 2019
@kyessenov
Copy link
Copy Markdown
Contributor

kyessenov commented May 31, 2019

Close/open sometimes does the trick.

@kyessenov kyessenov closed this May 31, 2019
@kyessenov kyessenov reopened this May 31, 2019
@bianpengyuan
Copy link
Copy Markdown
Contributor Author

bianpengyuan commented May 31, 2019

Still says review required. Let me recreated one then.

@utka
Copy link
Copy Markdown
Contributor

utka commented May 31, 2019

I saw it today with another PR, that tide got stuck. Let me check the logs

@bianpengyuan
Copy link
Copy Markdown
Contributor Author

bianpengyuan commented May 31, 2019

@utka Thanks! Fyi I recreated #2252, not sure if it could pass the tide check.

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented May 31, 2019

@bianpengyuan: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/proxy-presubmit-tsan.sh 186b683 link /test proxy-presubmit-tsan
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kyessenov kyessenov kyessenov left review comments

@PiotrSikora PiotrSikora Awaiting requested review from PiotrSikora

@lizan lizan Awaiting requested review from lizan

@mandarjog mandarjog Awaiting requested review from mandarjog

Assignees

@kyessenov kyessenov

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bianpengyuan @istio-testing @kyessenov @utka @googlebot