Skip to content

update envoy to latest#2158

Merged
duderino merged 6 commits intoistio:release-1.1from
lizan:envoy_update_fault
Apr 10, 2019
Merged

update envoy to latest#2158
duderino merged 6 commits intoistio:release-1.1from
lizan:envoy_update_fault

Conversation

@lizan
Copy link
Copy Markdown
Contributor

@lizan lizan commented Mar 28, 2019

Signed-off-by: Lizan Zhou lizan@tetrate.io

What this PR does / why we need it:
To pick up TLS logging, fault injection controlled by header.

Special notes for your reviewer:

Release note:

None

@lizan
update envoy to latest
883dc3f 
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Mar 28, 2019
@lizan lizan requested review from mandarjog and removed request for JimmyCYJ and duderino March 28, 2019 08:17
lizan and others added 4 commits March 28, 2019 13:33
@lizan
update envoy with latest build fixes (istio#2147)
1578cf8
@lizan
fix build
6f62df6 
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
@lizan
fix build
6e6f86a 
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
@mandarjog
fix formatting
3f6618b
mandarjog
mandarjog approved these changes Mar 28, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@mandarjog mandarjog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Mar 28, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lizan, mandarjog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lizan
fix status match
eef6690 
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
@duderino
Copy link
Copy Markdown

duderino commented Apr 5, 2019

@lizan thank you for this PR

@duderino
Copy link
Copy Markdown

duderino commented Apr 5, 2019

/retest because prow jobs are stuck on pending

@duderino
Copy link
Copy Markdown

duderino commented Apr 5, 2019

@utka can you take a look at the prow jobs on this PR? They have been stuck in the running state since 3/28

@utka
Copy link
Copy Markdown
Contributor

utka commented Apr 5, 2019

Triggered the test manually. Should be unstuck

@fejta
Copy link
Copy Markdown

fejta commented Apr 5, 2019

We have made a variety of changes to prow in the past six months. It would be a good idea to a) prioritize pulling in these changes and b) start using upstream prow like most others so that c) we can manage and support your prow instance

@duderino
Copy link
Copy Markdown

duderino commented Apr 10, 2019

@utka jobs still stuck

@utka
Copy link
Copy Markdown
Contributor

utka commented Apr 10, 2019

/test proxy-presubmit
/test proxy-presubmit-tsan

@lambdai lambdai mentioned this pull request Apr 10, 2019
Merged
@duderino
Copy link
Copy Markdown

duderino commented Apr 10, 2019

Force merging. @utka says she can debug the stuck prow jobs without this PR

@duderino duderino merged commit 5a9945b into istio:release-1.1 Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mandarjog mandarjog mandarjog approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mandarjog mandarjog

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@lizan @istio-testing @duderino @utka @fejta @mandarjog @googlebot