Skip to content

make build work with bazel 0.20#2068

Merged
mandarjog merged 1 commit intoistio:masterfrom
mandarjog:bazel_fix0.20
Dec 15, 2018
Merged

make build work with bazel 0.20#2068
mandarjog merged 1 commit intoistio:masterfrom
mandarjog:bazel_fix0.20

Conversation

@mandarjog
Copy link
Copy Markdown
Contributor

@mandarjog mandarjog commented Dec 15, 2018

http_archive is not a native function since bazel 0.19, so it must be imported.

@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Dec 15, 2018
@mandarjog mandarjog requested review from lizan and qiwzhang and removed request for sebastienvas and venilnoronha December 15, 2018 18:47
@mandarjog
Copy link
Copy Markdown
Contributor Author

mandarjog commented Dec 15, 2018

Without this change

mjog@devinstance:/mnt/disks/sdb/go/src/istio.io/proxy$ bazel build //...
WARNING: The following rc files are no longer being read, please transfer their contents or import their path into one of the standard rc files:
/mnt/disks/sdb/go/src/istio.io/proxy/tools/bazel.rc
Starting local Bazel server and connecting to it...
INFO: Invocation ID: 28344aa4-6e97-43f1-9b60-b98974bcb3cc
ERROR: error loading package '': Encountered error while reading extension file 'bazel/repositories.bzl': no such package '@envoy//bazel': The native http_archive rule is deprecated. load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") for a drop-in replacement.

venilnoronha
venilnoronha approved these changes Dec 15, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@venilnoronha venilnoronha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@lizan
Copy link
Copy Markdown
Contributor

lizan commented Dec 15, 2018

/lgtm
/approve

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Dec 15, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lizan, mandarjog, venilnoronha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mandarjog mandarjog merged commit 7c28b86 into istio:master Dec 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qiwzhang qiwzhang Awaiting requested review from qiwzhang

@lizan lizan Awaiting requested review from lizan

1 more reviewer

@venilnoronha venilnoronha venilnoronha approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lizan lizan

@venilnoronha venilnoronha

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mandarjog @lizan @istio-testing @venilnoronha @googlebot