Back port the fix for peerIsOptional/originIsOptional to 1.0 branch #1969
Merged
hklai merged 3 commits intoistio:release-1.0from Sep 13, 2018
Merged
Back port the fix for peerIsOptional/originIsOptional to 1.0 branch #1969hklai merged 3 commits intoistio:release-1.0from
hklai merged 3 commits intoistio:release-1.0from
Conversation
Contributor
Author
Contributor
Author
|
@hklai Could you approve this so that I can cherrypick it to Istio 1.0.3? Thank you. |
Member
|
/lgtm /approve |
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: diemtvu, JimmyCYJ The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
JimmyCYJ
approved these changes
Sep 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: In order to cherrypick this fix into Istio 1.0.3, we need back port the fix to 1.0 branch first.
Which issue this PR fixes: The same as #1959
Special notes for your reviewer: I manually excluded the test case
IgnoreBothPassadded in #1959 as it has dependencies on some other PRs in master branch which I think is too big to cherrypick to 1.0 branch.Severity: This patch is needed to fix a bug that makes the peerIsOptional/oritinIsOptional flag useless. Without the patch, the user identity cannot be passed to the next layer (i.e. Istio authorization) when the flag is set to true. This makes the authorization layer always deny the request due to the missing identities. Multiple users have reported this (#1892 #1958, and also from slack).
Release note: